Defect #20296

Double full stops in Japanese

Added by Masaki Nukaga almost 6 years ago. Updated over 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Translations
Target version:3.2.0
Resolution:Fixed Affected version:

Description

I think it's typo.

Fix-typo-japanese-translate.patch Magnifier (2.43 KB) Masaki Nukaga, 2015-07-12 07:58

ubuntu-11_10__Running_.png - before fix (443 KB) Masaki Nukaga, 2015-07-12 07:59

remove-fullstop.patch Magnifier (1.24 KB) Masaki Nukaga, 2015-07-17 17:45

Associated revisions

Revision 14470
Added by Toshi MARUYAMA over 5 years ago

remove activerecord.messages.messages full stops in Japanese (#20296)

Revision 14471
Added by Toshi MARUYAMA over 5 years ago

replace full stops by fullwidth in Japanese (#20296)

History

#1 Updated by Toshi MARUYAMA almost 6 years ago

  • Category changed from Issues to Translations

#2 Updated by Toshi MARUYAMA almost 6 years ago

  • Assignee set to Go MAEDA

It is strange. But I think "empty" is wrong.

$ grep -2 -n empty ja.yml en.yml 
ja.yml-132-        confirmation: "が一致しません。" 
ja.yml-133-        accepted: "を受諾してください。" 
ja.yml:134:        empty: "を入力してください。" 
ja.yml-135-        blank: "を入力してください。" 
ja.yml-136-        too_long: "は%{count}文字以内で入力してください。" 
--
en.yml-111-        confirmation: "doesn't match confirmation" 
en.yml-112-        accepted: "must be accepted" 
en.yml:113:        empty: "cannot be empty" 
en.yml-114-        blank: "cannot be blank" 
en.yml-115-        too_long: "is too long (maximum is %{count} characters)"

#3 Updated by Go MAEDA almost 6 years ago

I agree with the proposal to change notice_failed_to_save_members.

I think that changing strings derived from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/ja.yml is not good solution, because it increases our burden of maintenance.

#4 Updated by Toshi MARUYAMA almost 6 years ago

#5 Updated by Go MAEDA almost 6 years ago

  • Assignee deleted (Go MAEDA)

#6 Updated by Toshi MARUYAMA almost 6 years ago

  • Target version set to 3.2.0

#7 Updated by Toshi MARUYAMA almost 6 years ago

  • Subject changed from FIx typo japanese translation to Double full stop in Japanese

#8 Updated by Toshi MARUYAMA almost 6 years ago

  • Subject changed from Double full stop in Japanese to Double full stops in Japanese

#9 Updated by Masaki Nukaga over 5 years ago

Sorry,
I created a patch which changed part only.

If you're going to adapt https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/ja.yml that full stop is removed I think had better use "。" instead of "." in the notice_failed_to_save_members statement.

If you need it I create a patch.

#10 Updated by Toshi MARUYAMA over 5 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in trunk r14470 and r14471.

Also available in: Atom PDF