Defect #20296
closedDouble full stops in Japanese
Added by Masaki Nukaga about 9 years ago. Updated about 9 years ago.
0%
Description
I think it's typo.
Files
Fix-typo-japanese-translate.patch (2.43 KB) Fix-typo-japanese-translate.patch | Masaki Nukaga, 2015-07-12 07:58 | ||
ubuntu-11_10__Running_.png (443 KB) ubuntu-11_10__Running_.png | before fix | Masaki Nukaga, 2015-07-12 07:59 | |
remove-fullstop.patch (1.24 KB) remove-fullstop.patch | Masaki Nukaga, 2015-07-17 17:45 |
Updated by Toshi MARUYAMA about 9 years ago
- Category changed from Issues to Translations
Updated by Toshi MARUYAMA about 9 years ago
- Assignee set to Go MAEDA
It is strange. But I think "empty" is wrong.
$ grep -2 -n empty ja.yml en.yml ja.yml-132- confirmation: "が一致しません。" ja.yml-133- accepted: "を受諾してください。" ja.yml:134: empty: "を入力してください。" ja.yml-135- blank: "を入力してください。" ja.yml-136- too_long: "は%{count}文字以内で入力してください。" -- en.yml-111- confirmation: "doesn't match confirmation" en.yml-112- accepted: "must be accepted" en.yml:113: empty: "cannot be empty" en.yml-114- blank: "cannot be blank" en.yml-115- too_long: "is too long (maximum is %{count} characters)"
Updated by Go MAEDA about 9 years ago
I agree with the proposal to change notice_failed_to_save_members.
I think that changing strings derived from https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/ja.yml is not good solution, because it increases our burden of maintenance.
Updated by Toshi MARUYAMA about 9 years ago
I have sent pull request.
https://github.com/svenfuchs/rails-i18n/pull/565
Updated by Toshi MARUYAMA about 9 years ago
- Subject changed from FIx typo japanese translation to Double full stop in Japanese
Updated by Toshi MARUYAMA about 9 years ago
- Subject changed from Double full stop in Japanese to Double full stops in Japanese
Updated by Masaki Nukaga about 9 years ago
- File remove-fullstop.patch remove-fullstop.patch added
Sorry,
I created a patch which changed part only.
If you're going to adapt https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/ja.yml that full stop is removed I think had better use "。" instead of "." in the notice_failed_to_save_members statement.
If you need it I create a patch.
Updated by Toshi MARUYAMA about 9 years ago
- Status changed from New to Closed
- Resolution set to Fixed