Patch #21947
closed
Improve page header title for deeply nested project structures (+ improved XSS resilience)
0%
Description
Some theme developers (or even Redmine core, see below) may wish to put the project breadcrumbs within the page header title on a separate line, see screenshots attached.
Patch 0001 will add some extra span elements which make this possible for theme CSS. It also improves XSS resilience by using the safe_join helper instead of manually declaring strings .html_safe, see here and here. This patch shouldn't change things for existing themes and could therefore applied to core without any doubt, IMHO.
Patch 0002 actually changes Redmine's core CSS to take advantage of this and display the breadcrumbs on a separate line. I feel it looks better this way, but I realize that this is just my opinion, so I would see this patch as optional and up for discussion.
Old:
New:
Files
Related issues
Updated by Jan from Planio www.plan.io over 8 years ago
- Description updated (diff)
Updated by Jan from Planio www.plan.io over 8 years ago
- Description updated (diff)
Updated by Daniel Feliciano Branco over 8 years ago
I have the same problem on some of my projects, so a +1 from me.
Updated by Go MAEDA over 8 years ago
Great. I think this should be included in Redmine core.
But breadcrumbs in small and bold font are hard to read with non HDPI devices, especially when displaying CJK characters.
I suggest changing the style to the following:
#header h1 .breadcrumbs { display:block; font-size: .6em; font-weight: normal; }
Updated by Go MAEDA over 8 years ago
- Target version changed from Candidate for next minor release to 3.3.0
Setting target version to 3.3.0.
Updated by Jan from Planio www.plan.io over 8 years ago
Go MAEDA wrote:
I suggest changing the style to the following:
Sounds good to me! I must admit that I hadn't tested with CJK characters, but I agree that all texts should remain readable with all character sets, of course!
Updated by Jean-Philippe Lang over 8 years ago
- Status changed from Needs feedback to Closed
- Assignee set to Jean-Philippe Lang
Changes committed, thanks.
Updated by Go MAEDA about 8 years ago
- Has duplicate Defect #5261: Multiple level subprojects wrap around into the menu added
Updated by Ben Blanco almost 8 years ago
- File 2016-11-30_new_redmine_header.png 2016-11-30_new_redmine_header.png added
- File 2016-11-30_old_redmine_header.png 2016-11-30_old_redmine_header.png added
Hi,
I've upgraded to from 3.2.3 to 3.3.1, and now my header wraps even when they're short..
It's definitely cool that headers can be styled differently now, and wrap nicely when dealing with super-long-project-names, but for me we have two sub-levels max, and our names are short, yet I used to have this:
Now I have this:
We use circle theme v.2.0.2
Any help/indication on how I can fix this wrapping?
Updated by Toshi MARUYAMA almost 8 years ago
Ben Blanco wrote:
Hi,
...
Please create new issue for feature request, because this issue has closed.
Updated by Go MAEDA almost 7 years ago
- Related to Feature #7848: Add class for project title in the header added