Project

General

Profile

Actions
Copy link

Patch #21947

closed

Improve page header title for deeply nested project structures (+ improved XSS resilience)

Added by Jan from Planio www.plan.io about 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI
Target version:
3.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Some theme developers (or even Redmine core, see below) may wish to put the project breadcrumbs within the page header title on a separate line, see screenshots attached.

Patch 0001 will add some extra span elements which make this possible for theme CSS. It also improves XSS resilience by using the safe_join helper instead of manually declaring strings .html_safe, see here and here. This patch shouldn't change things for existing themes and could therefore applied to core without any doubt, IMHO.

Patch 0002 actually changes Redmine's core CSS to take advantage of this and display the breadcrumbs on a separate line. I feel it looks better this way, but I realize that this is just my opinion, so I would see this patch as optional and up for discussion.

Old:

Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-50-43.png

New:

Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-51-33.png

Files

Download all files
0001-Add-additional-markup-to-page_header_title-to-enable.patch (1.12 KB) 0001-Add-additional-markup-to-page_header_title-to-enable.patch Jan from Planio www.plan.io, 2016-02-04 07:49
0002-Put-project-breadcrumbs-in-page_header_title-on-sepa.patch (1.11 KB) 0002-Put-project-breadcrumbs-in-page_header_title-on-sepa.patch Jan from Planio www.plan.io, 2016-02-04 07:49
Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-50-43.png (161 KB) Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-50-43.png Jan from Planio www.plan.io, 2016-02-04 07:51
Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-51-33.png (155 KB) Overview - Sub-Subproject with a very long name - Redmine 2016-02-04 14-51-33.png Jan from Planio www.plan.io, 2016-02-04 07:51
screenshot-font-comparison.png (52.5 KB) screenshot-font-comparison.png Go MAEDA, 2016-02-05 01:54
2016-11-30_new_redmine_header.png (10.1 KB) 2016-11-30_new_redmine_header.png Ben Blanco, 2016-11-30 12:28
2016-11-30_old_redmine_header.png (12.2 KB) 2016-11-30_old_redmine_header.png Ben Blanco, 2016-11-30 12:28

Related issues

Related to Redmine - Feature #7848: Add class for project title in the headerClosed2011-03-13

Actions
Has duplicate Redmine - Defect #5261: Multiple level subprojects wrap around into the menuClosed2010-04-07

Actions
Actions
Copy link

Also available in: Atom PDF