Defect #22023
closed
Issue id input should get focus after adding related issue
Added by Jim Poserina over 8 years ago.
Updated over 6 years ago.
Description
Current behavior when adding multiple related issues:
- Click
Add
Issue #
text input has focus
- Enter issue number, press
Enter
key
- The add related issue subform stays open, but the
Issue #
input has lost focus
To add another related issue, you must either:
- Tab 5 times (to cycle through the
Add
link, the link to the related issue, the Delete relation
link, the relation type drop-down, and then the Issue #
input). Then to add a third issue, you must tab 7 times. For a fourth, 9 times, and so on.
- Move the mouse and re-click the text input.
- Click
Add
to close the subform and then Add
to reopen it, whereupon the Issue #
input receives focus.
The UI anticipates that you may need to enter multiple related issues as the subform stays open after each addition. Thus after a related issue is added the Issue #
input should retain focus.
This feature can be realized by the following small change.
diff --git a/app/views/issue_relations/create.js.erb b/app/views/issue_relations/create.js.erb
index 0c2e036cc5..1f296e66d4 100644
--- a/app/views/issue_relations/create.js.erb
+++ b/app/views/issue_relations/create.js.erb
@@ -2,6 +2,6 @@ $('#relations').html('<%= escape_javascript(render :partial => 'issues/relations
<% if @relation.errors.empty? %>
$('#relation_delay').val('');
$('#relation_issue_to_id').val('');
- $('#relation_issue_to_id').focus();
<% end %>
$('#new-relation-form').show();
+$('#relation_issue_to_id').focus();
\ No newline at end of file
- Target version set to 3.3.8
- Tracker changed from Feature to Defect
- Subject changed from Have the Issue # input retain focus after adding related issue to Issue ID input should get focus after adding related issue
- Affected version set to 2.4.0
This bug seems to be introduced in r11610 (Redmine 2.4.0).
- Subject changed from Issue ID input should get focus after adding related issue to Issue id input should get focus after adding related issue
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed to the trunk and stable branches. Thank you all for reporting and fixing this issue.
Also available in: Atom
PDF