Defect #22335
closed
Images with non-ASCII file names are not shown in PDF
Added by Go MAEDA over 8 years ago. Updated over 7 years ago.
0%
Description
Images with non-ASCII file names are not shown in PDF. Please see the following image. There are two embedded image "shrine.jpg" and "神社.jpg" in a issue description. But "神社.jpg" (an image with non-ASCII file name) are not shown in exported PDF.
Files
| issue-export-sample.pdf (113 KB) issue-export-sample.pdf | PDF with problem | Go MAEDA, 2016-03-29 06:53 | |
| defect-description.jpg (70.4 KB) defect-description.jpg | Go MAEDA, 2016-03-29 07:24 | ||
| cherryblossoms.png (36.4 KB) cherryblossoms.png | Kuniharu AKAHANE, 2016-07-14 06:15 | ||
| cherry blossoms.png (36.4 KB) cherry blossoms.png | Kuniharu AKAHANE, 2016-07-14 06:15 | ||
| exported_pdf.png (68.3 KB) exported_pdf.png | Kuniharu AKAHANE, 2016-07-14 06:56 | ||
| browser_view.png (155 KB) browser_view.png | Kuniharu AKAHANE, 2016-07-14 06:56 | ||
| 22335-with-rfpdf-1.19.1.pdf (275 KB) 22335-with-rfpdf-1.19.1.pdf | Go MAEDA, 2017-03-30 04:52 |
Updated by Kuniharu AKAHANE over 8 years ago
- File cherryblossoms.png cherryblossoms.png added
- File cherry blossoms.png cherry blossoms.png added
Hi, Go Maeda.
Thanks for reporting this issue here.
I reproduced this issue on our site.
Just for your information,
Not only images with non-ASCII file names but also with ASCII file names which includes special characters are not shown in PDF.
I guess url-encoding or url-handling of file-path cause this issue. (somewhere in rbpdf ?)
Examples:
# cherryblossoms.png !cherryblossoms.png! # cherry blossoms.png (include space character, not shown ) !cherry blossoms.png! # cherry%20blossoms.png (include space character with url encoded, shown in browser but not in PDF) !cherry%20blossoms.png!
- On browser
- Exported PDF
Show logs on our web-siteShow logs on our web-site
Started GET "/its/issues/196178.pdf" for <ipaddress> at 2016-07-14 14:17:42 +0900
Processing by IssuesController#show as PDF
Parameters: {"id"=>"196178"}
Current user: kakahane (id=***)
pdf: Image: error: RBPDF error: Image filename is empty.
pdf: Image: error: RBPDF error: Image filename is empty.
Rendered issues/show.pdf.erb (88.5ms)
Completed 200 OK in 106ms (Views: 88.3ms | ActiveRecord: 3.0ms)
Out-Of-Bound GC finished in 0.115697521 sec
Repoduced Environment-1Repoduced Environment-1
$ uname -a Linux 3.10.0-327.13.1.el7.x86_64 #1 SMP Thu Mar 31 16:04:38 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux $ cat /etc/centos-release CentOS Linux release 7.2.1511 (Core) Environment: Redmine version 3.0.7.stable Ruby version 2.1.7-p400 (2015-08-18) [x86_64-linux] Rails version 4.2.3 Environment production Database adapter Mysql2 SCM: Subversion 1.8.14 Mercurial 2.6.2 Git 2.6.4 Filesystem Redmine plugins: clipboard_image_paste 1.10 redmine_exception_handler 2.0.0.devel.56f6d28645 redmine_importer 1.2.2 redmine_plugin_views_revisions 0.0.1 redmine_vividtone_my_page_blocks 20150614 redmine_work_time 0.3.1 redmine_xls_export 0.2.1.t8 wiki_external_filter 0.0.2 Gems: htmlentities (4.3.1) passenger (4.0.59) rbpdf (1.18.7, 1.18.6) rmagick (2.13.4)
Repoduced Environment-2Repoduced Environment-2
$ uname -a Linux 2.6.32-573.22.1.el6.x86_64 #1 SMP Wed Mar 23 03:35:39 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux $ cat /etc/centos-release CentOS release 6.7 (Final) Environment: Redmine version 3.1.4.stable Ruby version 2.2.4-p230 (2015-12-16) [x86_64-linux] Rails version 4.2.5.2 Environment production Database adapter Mysql2 SCM: Subversion 1.8.15 Mercurial 1.4 Git 1.7.1 Filesystem Redmine plugins: clipboard_image_paste 1.10 redmine_exception_handler 2.0.0.devel.56f6d28645 redmine_importer 1.2.2 redmine_plugin_views_revisions 0.0.1 redmine_vividtone_my_page_blocks 20150614 redmine_work_time 0.3.1 redmine_xls_export 0.2.1.t9 wiki_external_filter 0.0.2 Gems: htmlentities (4.3.1) passenger (5.0.27) rbpdf (1.18.7) rmagick (2.15.4)
Updated by Kuniharu AKAHANE over 8 years ago
- File exported_pdf.png exported_pdf.png added
- File browser_view.png browser_view.png added
Opps, Add captured images.
Updated by Jun NAITOH over 7 years ago
This problem fixed by rbpdf 1.19.1.
please bundle update.
Updated by Kuniharu AKAHANE over 7 years ago
Thanks you very much for your time, naito-san.
I tried rbpdf 1.19.1 on our all redmine instanses.
The problem seems to be fixed so far.
Environment:
Redmine version 3.3.2.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux] Rails version 4.2.7.1 Environment production Database adapter Mysql2
bundle update results:
Using rbpdf-font 1.19.1 (was 1.19.0) Using rbpdf 1.19.1 (was 1.19.0)
Updated by Go MAEDA over 7 years ago
- File 22335-with-rfpdf-1.19.1.pdf 22335-with-rfpdf-1.19.1.pdf added
- Status changed from New to Closed
- Resolution set to Fixed
I confirmed that images with a file name which contains non-ASCII and whitespace characters is rendered properly after updating to rfpdf 1.19.1 by executing bundle update.
Thank you for working on this, Naitoh-san. We can close this issue.
Note for those who are in trouble with this problem:
Please run the following commands on your Redmine server.
cd /path/to/redmine bundle update
Updated by Toshi MARUYAMA over 7 years ago
- Status changed from Closed to New
- Target version changed from 3.2.6 to 3.4.0
- Resolution deleted (
Fixed)
Updated by Toshi MARUYAMA over 7 years ago
- Blocked by Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required added
Updated by Jean-Philippe Lang over 7 years ago
- Target version changed from 3.4.0 to 3.2.6
Updated by Toshi MARUYAMA over 7 years ago
- Blocked by deleted (Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required)
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Fixed with rbpdf 1.19.2.