Project

General

Profile

Actions

Defect #23751

closed

Tab buttons appear on pages that have no tabs

Added by Edouard Cunibil about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The JS condition that's supposed to hide the tab buttons checks if the first LI element is visible or not.
If there is no LI element, the tab buttons are always shown.

file: public/javascripts/application.js
line: 383

replace:

if ((tabsWidth < el.width() - bw) && (lis.first().is(':visible'))) {

by:

if ((tabsWidth < el.width() - bw) && (lis.length === 0 || lis.first().is(':visible'))) {

In case it helps, here is my environemt:

Environment:
  Redmine version                3.3.0.stable
  Ruby version                   2.1.5-p273 (2014-11-13) [x86_64-linux-gnu]
  Rails version                  4.2.6
  Environment                    production
  Database adapter               Mysql2
SCM:
  Git                            2.1.4
  Filesystem                     
Redmine plugins:
  redmine_agile                  1.4.1
  redmine_backlogs               v1.0.6
  redmine_checklists             3.1.3

Sorry not provinding a patch but I'm a Git guy so I don't have anything related to SVN installed on my system.


Files

fix-tabs.diff (934 Bytes) fix-tabs.diff Edouard Cunibil, 2016-09-02 13:29
23751.jpg (158 KB) 23751.jpg Go MAEDA, 2016-09-04 05:34
Actions

Also available in: Atom PDF