Defect #24457
closed
Progress of version should be calculated the same way as parent tasks
Added by C-O L about 8 years ago. Updated 8 months ago.
0%
Description
The progress of a version should be calculated the same ways as the progress of parent tasks are calculated in #23511.
Files
| done_ratio_for_version.diff (1.44 KB) done_ratio_for_version.diff | C-O L, 2016-11-25 16:06 | ||
| 0001-Version-progress-should.patch (2.74 KB) 0001-Version-progress-should.patch | Marius BĂLTEANU, 2019-03-31 23:26 |
Related issues
Updated by Toshi MARUYAMA about 8 years ago
- Tracker changed from Defect to Feature
- Description updated (diff)
- Category set to Roadmap
Updated by Toshi MARUYAMA about 8 years ago
- Related to Defect #23511: Progress of parent task should be calculated using total estimated hours of children added
Updated by C-O L about 8 years ago
The progress for version is not calculated correctly.
It only uses the estimated time for issues in the version so if mixing issues with an estimated time >0.0h and issues without an estimated time then the issues without an estimated time is not contributing to the progress at all.
It should also use the total_estimated_time instead of just estimated_time, this will make the progress correct if the parent is in the version but not the children.
I've attached a fix that shows what I had in mind.
Updated by Toshi MARUYAMA about 8 years ago
- Tracker changed from Feature to Defect
Updated by Toshi MARUYAMA about 8 years ago
Could you add tests?
source:trunk/test/unit/version_test.rb@15993#L80
Updated by C-O L about 8 years ago
I'll see if I can squeeze in some time for this in the near future.
Updated by Marius BĂLTEANU over 5 years ago
- Related to Defect #4682: Completed version with wrong progress bar status added
Updated by Marius BĂLTEANU over 5 years ago
- File 0001-Version-progress-should.patch 0001-Version-progress-should.patch added
- Assignee changed from Marius BĂLTEANU to Jean-Philippe Lang
- Target version set to 4.1.0
I've updated the patch posted by C-O-L and added to it a test posted by Etienne some years ago to #4682. I can confirm that this patch fixes the related issue (#4682), but I'm not sure about the defect reported here.
From my point of view, we should take into account the total estimated hours (as the patch proposes), but I'm not sure that issues estimated at 0 hours should be treated in the same way as the issues without estimated hours.
Also, the patch generates quite a lot of queries.
I'm assigning this to 4.1.0 to clarify at least the expected behaviour. I think it could be an important fix.
Updated by Go MAEDA about 5 years ago
- Target version changed from 4.1.0 to 4.2.0
Updated by Marius BĂLTEANU almost 4 years ago
- Target version changed from 4.2.0 to 5.0.0
Updated by Marius BĂLTEANU over 2 years ago
- Target version changed from 5.0.0 to 5.1.0
Updated by Kamil . almost 2 years ago
@Jean-Philippe, since you are finally working on calculating progress - maybe it'll be a good idea to take also this issue into account: #6975? (since Issue Done Ratio Both doesn't seem to be supporting new versions of Redmine anymore)
Kind regards
Updated by Go MAEDA about 1 year ago
- Target version changed from 5.1.0 to 6.0.0
Updated by Marius BĂLTEANU 8 months ago
- Status changed from New to Closed
- Assignee changed from Jean-Philippe Lang to Marius BĂLTEANU
- Resolution set to Fixed
This is a very old issue and I've committed the fix from my previous patch in order to have the same behaviour from parent task. Regarding the difference between issues without estimated time and issues with estimated time 0, we can track this change in another ticket if it's desired.