Feature #24577: Settings to make the issue and/or comment fields mandatory for time logs - Redmine

Actions

Copy link

Feature #24577

closed

Settings to make the issue and/or comment fields mandatory for time logs

Added by Marius BĂLTEANU over 7 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Time tracking

Target version:

3.4.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Description

The attached patch adds the following changes:

a new tab in the application settings named "Time tracking"
new settings to make the issue and/or comment fields mandatory for time logs. By default, the new settings are off in order to not change the current behaviour.

The patch implements the following tickets:

Files

Download all files

time_tracking_settings.png (44.1 KB) time_tracking_settings.png		Marius BĂLTEANU, 2016-12-11 01:19
settings_to_make_issue_id_comment_fields_mandatory.patch (4.56 KB) settings_to_make_issue_id_comment_fields_mandatory.patch		Marius BĂLTEANU, 2016-12-11 02:12
settings_to_make_issue_id_comment_fields_mandatory_v2.patch (5.05 KB) settings_to_make_issue_id_comment_fields_mandatory_v2.patch		Marius BĂLTEANU, 2016-12-11 02:21

Related issues

Related to Redmine - Defect #28110: Don't allow reassigning reported hours to the project if issue is a required field for time logs

Closed

Go MAEDA

Actions

Has duplicate Redmine - Feature #4885: Option to make time log comments field mandatory

Closed

2010-02-20

Actions

Has duplicate Redmine - Feature #12236: Option to make Comment field required

Closed

Actions

Has duplicate Redmine - Feature #19813: Spent time comment mandatory

Closed

Actions

Has duplicate Redmine - Defect #24049: Records in table time_entries with null value at field issue_id

Closed

Actions

Has duplicate Redmine - Patch #2196: Do not save @time_entry if comment/hour is nil

Closed

2008-11-15

Actions

Has duplicate Redmine - Feature #11039: Disable time tracking for projects

Closed

Actions

Has duplicate Redmine - Feature #4690: Make it configurable to make the issue number mandatory when booking hours

Closed

2010-01-29

Actions

Has duplicate Redmine - Defect #29287: Log time allows pushing time entries without specifying any issue number

Closed

Actions

Copy link

Updated by Marius BĂLTEANU over 7 years ago

File settings_to_make_issue_id_comment_fields_mandatory_v2.patch settings_to_make_issue_id_comment_fields_mandatory_v2.patch added

Attached the correct patch.

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Feature #4885: Option to make time log comments field mandatory added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Feature #12236: Option to make Comment field required added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Feature #19813: Spent time comment mandatory added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Defect #24049: Records in table time_entries with null value at field issue_id added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Target version set to Candidate for next major release

This is a long awaited feature. There are at least 4 duplicate issues.
The patch works fine for me.

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Patch #2196: Do not save @time_entry if comment/hour is nil added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Feature #11039: Disable time tracking for projects added

Actions

Copy link

Updated by Go MAEDA over 7 years ago

Has duplicate Feature #4690: Make it configurable to make the issue number mandatory when booking hours added

Actions

Copy link

#10

Updated by Go MAEDA over 7 years ago

Target version changed from Candidate for next major release to 3.4.0

There are many duplicate issues, many people longing for this feature.
Setting target version to 3.4.0.

Actions

Copy link

#11

Updated by Jean-Philippe Lang over 7 years ago

Tracker changed from Patch to Feature
Status changed from New to Closed
Assignee set to Jean-Philippe Lang
Resolution set to Fixed

Patch committed, thanks. It's a nice addition.

Actions

Copy link

#12

Updated by ivan perez almost 7 years ago

Hello, this is a very good addition, i tried to apply the patch but my company is argentitnian so we have the spanish version, can anybody help me?, because this patch modify the en.yml file and in my case i have to modify the ES.yml file.

I can't wait until the 3.4 version comes...

i have redmine 3.2.2 so, i wait for your answer.

PD: it will be perfect if the patch allows to choose witch type of issue i want to make it mandatory..

If anybody can make the patch for redmine 3.2.2 spanish version and allows me to choose the type of issue i want to make it mandatory i will apreciate it so much.

Thanks a lot i wait for your answers

(Sorry for my english)

Actions

Copy link

#13

Updated by Pierre de LESPINAY over 6 years ago

I tried to apply the patch in a version 3.2.5-1 (Since I can't just upgrade to 3.4)

/home/redmine/redmine$ patch -p1 < settings_to_make_issue_id_comment_fields_mandatory_v2.patch

But I have 3 fails:

patching file app/helpers/settings_helper.rb
patching file app/models/time_entry.rb
patching file app/views/settings/_timelog.html.erb
patching file app/views/timelog/_form.html.erb
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file app/views/timelog/_form.html.erb.rej
patching file config/locales/en.yml
Hunk #1 FAILED at 448.
1 out of 1 hunk FAILED -- saving rejects to file config/locales/en.yml.rej
patching file config/settings.yml
Hunk #1 FAILED at 279.
1 out of 1 hunk FAILED -- saving rejects to file config/settings.yml.rej
patching file test/unit/time_entry_test.rb

Is it supposed to be applyable on a 3.2.5-1 version ?

Actions

Copy link

#14