Project

General

Profile

Actions

Defect #2473

closed

Login and mail should not be case sensitive

Added by Teddy L about 15 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Accounts / authentication
Target version:
Start date:
2009-01-08
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method find_by_login need a fix to be case insensitive like find_by_mail.

For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of find_by_login matching "login" with "login" but not "login" with "Login" ...


Files

user_rb.patch (1.56 KB) user_rb.patch Patch file for user.rb generated by TortoiseSVN 1.5.6 Teddy L, 2009-01-08 21:24
redmine-0.9-stable-r3695-login_case_insensitive.patch (1.18 KB) redmine-0.9-stable-r3695-login_case_insensitive.patch Case insensitive login patch for the Redmine 0.9-stable Stanislav German-Evtushenko, 2010-04-29 13:25

Related issues

Related to Redmine - Patch #4732: Make login case-insensitive also for PostgreSQLClosedEric Davis2010-02-03

Actions
Has duplicate Redmine - Feature #2330: Option for able to turn on case insensitive loginClosed2008-12-12

Actions
Actions #1

Updated by Stanislav German-Evtushenko about 15 years ago

Duplicate #2330

Actions #2

Updated by Tony Arnold about 15 years ago

Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.

Actions #3

Updated by Stanislav German-Evtushenko about 14 years ago

Tony Arnold wrote:

Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.

It will be great if it's included in redmine. We have the same problem.

Actions #4

Updated by Stanislav German-Evtushenko about 14 years ago

Teddy L wrote:

Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method find_by_login need a fix to be case insensitive like find_by_mail.

For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of find_by_login matching "login" with "login" but not "login" with "Login" ...

Thank you, Teddy! Your patch works with 0.8-stable!

Actions #6

Updated by Marcel Waldvogel almost 14 years ago

Patch #4732 addresses the same problem, but there at least PostgreSQL and MySQL should use the index instead of a table scan.

Dear maintainers: Please do include one of those fixes!

Actions #7

Updated by Eric Voisard almost 14 years ago

Just a comment: In the SMTP point of view, the local part of email addresses IS case-sensitive (RFC821, RFC822, RFC2821). is not the same mailbox as . Don't you think considering email addresses as case insensitive could have some undesired side effects?...

Actions #8

Updated by Felix Schäfer over 13 years ago

  • Target version set to 1.0.0 (RC)
Actions #10

Updated by Eric Davis over 13 years ago

  • Status changed from New to Closed
  • Assignee set to Eric Davis
  • % Done changed from 0 to 100
  • Resolution set to Fixed

I've committed a patch by Greg Mefford that makes the user login's case insensitive (r3807).

Actions

Also available in: Atom PDF