Defect #2473
closed
Login and mail should not be case sensitive
Added by Teddy L over 15 years ago.
Updated about 14 years ago.
Category:
Accounts / authentication
Description
Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method find_by_login need a fix to be case insensitive like find_by_mail.
For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of find_by_login matching "login" with "login" but not "login" with "Login" ...
Files
Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.
Tony Arnold wrote:
Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.
It will be great if it's included in redmine. We have the same problem.
Teddy L wrote:
Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method find_by_login need a fix to be case insensitive like find_by_mail.
For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of find_by_login matching "login" with "login" but not "login" with "Login" ...
Thank you, Teddy! Your patch works with 0.8-stable!
Patch #4732 addresses the same problem, but there at least PostgreSQL and MySQL should use the index instead of a table scan.
Dear maintainers: Please do include one of those fixes!
Just a comment: In the SMTP point of view, the local part of email addresses IS case-sensitive (RFC821, RFC822, RFC2821). username@domain.org is not the same mailbox as Username@domain.org. Don't you think considering email addresses as case insensitive could have some undesired side effects?...
- Target version set to 1.0.0 (RC)
- Status changed from New to Closed
- Assignee set to Eric Davis
- % Done changed from 0 to 100
- Resolution set to Fixed
I've committed a patch by Greg Mefford that makes the user login's case insensitive (r3807).
Also available in: Atom
PDF