Project

General

Profile

Actions
Copy link

Feature #25052

closed

Allow to disable description field in tracker setting

Added by Go MAEDA almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Issues
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Since we can create a full width layout custom field which look like a description field in upcoming 3.4.0 (#21705), I think that we will sometimes want to replace a description field with a full width layout custom field for better and specific naming of the field.

I am sure that it would be great if Redmine 3.4.0 has an ability to disable description field on TrackersController#edit page, along with #21705.

Files

Download all files
disable-description-field.diff (956 Bytes) disable-description-field.diff patch Go MAEDA, 2017-02-12 04:09
disable-description-field_fixed-test.diff (1.57 KB) disable-description-field_fixed-test.diff Mischa The Evil, 2017-02-15 07:58

Related issues

Related to Redmine - Feature #15918: Managing "description" fieldClosed2009-12-11

Actions
Related to Redmine - Patch #21705: Option for long text custom fields to be displayed using full widthClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Go MAEDA almost 8 years ago

Actions
Copy link
 #2

Updated by Go MAEDA almost 8 years ago

  • Related to Patch #21705: Option for long text custom fields to be displayed using full width added
Actions
Copy link
 #3

Updated by Marius BĂLTEANU almost 8 years ago

Thanks Go MAEDA for this patch. It was on my plan to create it because we need it on the following use case:
- we want to define a "Test Case" tracker with 3 fields instead of the description field: Preconditions, Steps, Expected Results.

Currently, we can define the new fields, but we aren't able to disable the description.

Actions
Copy link
 #4

Updated by Go MAEDA almost 8 years ago

  • Target version set to 3.4.0

I think this feature will make #21705 much greater.
Setting target version to 3.4.0.

Actions
Copy link
 #5

Updated by Mischa The Evil almost 8 years ago

Go MAEDA wrote:

[...] that it would be great if Redmine 3.4.0 has an ability to disable description field on TrackersController#edit page, along with #21705.

Although I'm not very glad with the integration of #21705, I do think that the ability to disable the description field for trackers would be a good addition to it.

I did some quick tests with your patch applied, and it seems to work without any side-effects. But this is something to look-out for by enabling the field to be disabled, as this is a long-time expectation (plugins?).
There is a test that fails with the changes applied though: IssueTest#test_safe_attributes_names_should_not_include_disabled_field (source:/trunk/test/unit/issue_test.rb@16333#L806). This is however expected as we've turned the description field to be 'disablable'. I'll leave an updated, fixed (SVN) patch against source:/trunk@16333 which adds the removal of the test assertion.

Actions
Copy link
 #6

Updated by Go MAEDA almost 8 years ago

Mischa The Evil wrote:

There is a test that fails with the changes applied though: IssueTest#test_safe_attributes_names_should_not_include_disabled_field (source:/trunk/test/unit/issue_test.rb@16333#L806). This is however expected as we've turned the description field to be 'disablable'. I'll leave an updated, fixed (SVN) patch against source:/trunk@16333 which adds the removal of the test assertion.

Thanks, I had missed it.

Actions
Copy link
 #7

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks to both of you.

Actions
Copy link

Also available in: Atom PDF