Patch #2607
Avatars display in forums
| Status: | Closed | Start date: | 2009-01-28 | ||
|---|---|---|---|---|---|
| Priority: | Normal | Due date: | |||
| Assignee: |  Jean-Philippe Lang | % Done: | 90% | ||
| Category: | Forums | ||||
| Target version: | - |
Description
Not sure what format you want your patches in, so I'll just include this here.
app/views/messages/show.rhtml from release 0.8.0, between lines 32 and 33
<%= avatar(message.user, :size => "32") %>
application.css 
- public/stylesheets/application.css (modified from 0.8.0)
(22.3 KB)
show.rhtml
- app/views/messages/show.rhtml (modified from 0.8.0)
(3.2 KB)
application.css
- public/stylesheets/application.css
(22.4 KB)
avatars.patch
(1.58 KB)
Related issues
History
#1
Updated by Brad Beattie over 13 years ago
Kay, just went and tested this idea out. Two changes.
message.user didn't work, but message.author does. Change app/views/messages/show.rhtml between lines 32 and 33:
<%= avatar(message.author, :size => "32") %>
The avatars need to float left. Include .message img.gravatar in public/stylesheets/application.css on line 645
#history img.gravatar,
.message img.gravatar {
#2
Updated by Brad Beattie over 13 years ago
Hrm. On one-line posts, this can cause the subsequent message h4 to indent incorrectly.
#3
Updated by Brad Beattie over 13 years ago
Brad Beattie wrote:
Hrm. On one-line posts, this can cause the subsequent message h4 to indent incorrectly.
Well, clear: left is certainly an option, but that would require the contextual div to be included in the message div. That makes sense as that's how journal divs are working now and consistency is awesome like that.
#4
Updated by Brad Beattie over 13 years ago
- File application.css added
- File show.rhtml added
#5
Updated by Brad Beattie over 13 years ago
- Assignee set to Jean-Philippe Lang
- % Done changed from 0 to 90
Okay, done. I just need someone to review it and integrate it if appropriate.
#7
Updated by Jean-Philippe Lang over 13 years ago
Brad, you should submit your changes using a single patch file.
It's much more easy to review and apply.
You can generate a patch file using svn diff command.
#8
Updated by Brad Beattie over 13 years ago
- File avatars.patch added
Right you are, good sir. When I made this ticket I was still getting into the swing of things.
#9
Updated by Oshyan Greene over 12 years ago
Is this planned for inclusion in a future version? The forums are a bit hard to read at the moment without visual poster identity context. This would help a lot. Thanks!
#10
Updated by Felix Schäfer over 12 years ago
- Status changed from New to Closed