Patch #2607
closed
Avatars display in forums
Added by Brad Beattie almost 16 years ago.
Updated over 14 years ago.
Description
Not sure what format you want your patches in, so I'll just include this here.
app/views/messages/show.rhtml from release 0.8.0, between lines 32 and 33
<%= avatar(message.user, :size => "32") %>
Files
Kay, just went and tested this idea out. Two changes.
message.user didn't work, but message.author does. Change app/views/messages/show.rhtml between lines 32 and 33:
<%= avatar(message.author, :size => "32") %>
The avatars need to float left. Include .message img.gravatar in public/stylesheets/application.css on line 645
#history img.gravatar,
.message img.gravatar {
Hrm. On one-line posts, this can cause the subsequent message h4 to indent incorrectly.
Brad Beattie wrote:
Hrm. On one-line posts, this can cause the subsequent message h4 to indent incorrectly.
Well, clear: left
is certainly an option, but that would require the contextual div to be included in the message div. That makes sense as that's how journal divs are working now and consistency is awesome like that.
- Assignee set to Jean-Philippe Lang
- % Done changed from 0 to 90
Okay, done. I just need someone to review it and integrate it if appropriate.
Brad, you should submit your changes using a single patch file.
It's much more easy to review and apply.
You can generate a patch file using svn diff
command.
Right you are, good sir. When I made this ticket I was still getting into the swing of things.
Is this planned for inclusion in a future version? The forums are a bit hard to read at the moment without visual poster identity context. This would help a lot. Thanks!
- Status changed from New to Closed
As far as I can tell, this is a dupe of #4468, which has been fixed in 0.9.0.
Also available in: Atom
PDF