Project

General

Profile

Actions
Copy link

Defect #26379

closed

Fix thumbnail rendering for images with height >> width

Added by Gabriel Cardoso over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Attachments
Target version:
3.4.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
3.4.0

Description

The ImageMagick format rule being `100x100>` (given 100 as thumbnail size in settings), when uploading images with a height much greater than the width (like websites templates) the thumbnail will have a height of 100px and a computed width so homothety is respected.

In the `thumbnail_tag` helper from `ApplicationHelper`, the width attribute is set width `Setting.thumbnails_size`. I suggest to remove this attribute from the image tag since the source thumbnail has the right size.

Am I missing some cases where this change could have an important impact ?

Files

Download all files
very high image example.jpg (89.6 KB) very high image example.jpg Gabriel Cardoso, 2017-07-07 12:02
26379-3_3@2x.png (15.7 KB) 26379-3_3@2x.png Go MAEDA, 2017-07-08 10:17
26379-3_4@2x.png (64.6 KB) 26379-3_4@2x.png Go MAEDA, 2017-07-08 10:17
defect-26379.diff (775 Bytes) defect-26379.diff Go MAEDA, 2017-07-09 08:37
Actions
Copy link

Also available in: Atom PDF