Redmine

Here's an updated patch based on feedback that meineerde gave me on IRC.

• An unknown operator leads to invalid SQL, return nil early instead
• NUMERIC is a non-standard PostgreSQL type, use DECIMAL instead

I think it would be better to move the position of "Spent time" filter in the filters list. The reasons are as follows:

• The proposed patch places the filter in the third position. I think it is a too excellent position for the filter because most users don't use the filter so frequently.
• "Spent time" and "Estimated time" are closely related to each other. These two filters should be next to each other.

Attaching an updated patch.

Before:

After:

I tested the patch "issue-filter-by-spent-time-3.diff" posted by Go Maeda.
As a result, I found that it is necessary to add a fixture of time_entrys to the test code "test/unit/query_test.rb".
Tests were done with MySQL, PostgreSQL, SQLite and all succeeded.
I attach a new patch that added fixture.

I noticed that 'expected' and 'actual' are reversed on the added assertions.
Attaching an updated patch.

Committed the patch. Thank you for improving Redmine.