Project

General

Profile

Actions

Patch #28169

closed

Enable and add underline button to the toolbar for Markdown formatting

Added by Marius BĂLTEANU about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Textile formatting has the "Underline" option for text formatting and I find it useful to have it also for Markdown.

The attached patch implements this.

As a side note, until this patch, the '_' was an alternative to '*' (italic), but I don't think that many users were aware by this alternative because Redmine uses the '*' in help docs and in the generated markup by Italic button.


Files


Related issues

Related to Redmine - Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text is declared as privateClosedGo MAEDA

Actions
Actions #1

Updated by Mischa The Evil about 6 years ago

  • Target version set to Unplanned backlogs

LGTM.

Actions #2

Updated by Marius BĂLTEANU about 6 years ago

  • File deleted (0001-enable-and-adds-underline-button-for-markdown-format.patch)
Actions #3

Updated by Marius BĂLTEANU about 6 years ago

Updated the patch to apply cleanly after r17198. It'll be nice to deliver this feature along with #28119.

Actions #4

Updated by Mischa The Evil about 6 years ago

  • Target version changed from Unplanned backlogs to 4.0.0

Marius BALTEANU wrote:

It'll be nice to deliver this feature along with #28119.

I agree. I don't see any reason why it shouldn't be possible.

Actions #5

Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from New to Closed

Patch committed, thanks!

Actions #6

Updated by Go MAEDA over 5 years ago

  • Assignee set to Jean-Philippe Lang
Actions #7

Updated by Marius BĂLTEANU over 4 years ago

  • Related to Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text is declared as private added
Actions

Also available in: Atom PDF