Replace "Cancel" buttons from the modals with "Cancel" link
|Assignee:||Go MAEDA||% Done:|
In the current UI, the main action for a form is represented by a button element (eg: Create, Create and continue, Add, etc) and the "Cancel" action is represented by a link. This is a very useful because the main action should be more evident for an user.
In the modals (Export to CSV, Add watchers, Add members), both actions (main and cancel) are represented by a button and this is confusing. The attached patch replaces all the cancel buttons from the modals with the same "Cancel" link used in the rest of the app.
#3 Updated by Go MAEDA almost 3 years ago
- File patch-29848-v2.patch added
Updated the patch for the current trunk (r17612).
$ patch -p1 < 0001-replace-Cancel-button-in-the-modals-with-a-Cancel-li.patch patching file app/views/groups/_new_users_modal.html.erb patching file app/views/issue_categories/_new_modal.html.erb patching file app/views/issues/index.html.erb Hunk #1 FAILED at 45. 1 out of 1 hunk FAILED -- saving rejects to file app/views/issues/index.html.erb.rej patching file app/views/members/_new_modal.html.erb patching file app/views/principal_memberships/_new_modal.html.erb patching file app/views/sudo_mode/_new_modal.html.erb patching file app/views/timelog/index.html.erb Hunk #1 FAILED at 33. 1 out of 1 hunk FAILED -- saving rejects to file app/views/timelog/index.html.erb.rej patching file app/views/versions/_new_modal.html.erb patching file app/views/watchers/_new.html.erb patching file app/views/wiki/_new_modal.html.erb Hunk #1 succeeded at 24 (offset 8 lines).
#7 Updated by Marius BALTEANU almost 3 years ago
@Go Maeda, I've removed from your updated patch some unnecessary changes.