Project

General

Profile

Actions
Copy link

Defect #28689

closed

csv 1.0.2 gem breaks ImportsControllerTest

Added by Go MAEDA over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Gems support
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

This issue is reproducible only on Ruby 2.5 because csv gem is used for Ruby 2.5 only (see r17245). No problem with csv 1.0.1.

$ ruby test/functional/imports_controller_test.rb
Run options: --seed 38551

# Running:

.......F

Failure:
ImportsControllerTest#test_post_settings_with_wrong_encoding_should_display_error [test/functional/imports_controller_test.rb:125]:
<(?-mix:not a valid UTF-8 encoded file)> expected but was
<The file is not a CSV file or does not match the settings below>..
Expected 0 to be >= 1.

bin/rails test test/functional/imports_controller_test.rb:111

Files

Download all files
28689.diff (1.32 KB) 28689.diff patch Go MAEDA, 2018-05-06 04:43
28689-v2.diff (1.43 KB) 28689-v2.diff patch (also supports Ruby 2.2) Go MAEDA, 2018-05-06 07:31

Related issues

Related to Redmine - Feature #27849: Ruby 2.5 supportClosedJean-Philippe Lang

Actions
Related to Redmine - Patch #28112: CsvTest fails due to a regression in Ruby 2.5ClosedGo MAEDA

Actions
Actions
Copy link

Also available in: Atom PDF