Project

General

Profile

Actions

Patch #29189

closed

Display custom fields on group pages

Added by Gregor Schmidt over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Custom fields
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

It's possible to add custom fields to groups, but they are no where displayed but in the edit view within the admin area.

The attached patch extends groups#show to also list custom fields defined for the group. It's targeted at r17428.


Files

0001-Show-group-custom-fields-on-group-view-page.patch (998 Bytes) 0001-Show-group-custom-fields-on-group-view-page.patch Gregor Schmidt, 2018-07-04 14:19
screenshot-29189@2x.png (16.3 KB) screenshot-29189@2x.png Go MAEDA, 2018-07-04 15:33
29189.patch (625 Bytes) 29189.patch Go MAEDA, 2018-07-05 14:30
add_test_to_29189_patch.patch (1.3 KB) add_test_to_29189_patch.patch Mizuki ISHIKAWA, 2018-07-06 06:45
Actions #1

Updated by Go MAEDA over 5 years ago

This is a screenshot of /groups/:id page after applying the patch.

Actions #2

Updated by Go MAEDA over 5 years ago

  • Assignee set to Gregor Schmidt

Thank you for posting the patch. I think this patch improves the consistency of UI.

But I wonder whether the heading "Attributes" is necessary. /users/:id page does not add such a heading when showing custom fields (see http://www.redmine.org/users/347 for example). In addition, :label_attribute_plural is only used in app/views/auth_sources/_form_auth_source_ldap.html.erb.

Do you think we can remove "<h3><%= l(:label_attribute_plural) %></h3>" from the patch?

Actions #3

Updated by Gregor Schmidt over 5 years ago

Thank you for reviewing this patch.

I don't have a strong opinion on this one. I've added the sub heading for cosmetic reasons. If you think it's not necessary, this is OK for me.

Actions #4

Updated by Go MAEDA over 5 years ago

I have slightly changed Gregor Schmidt's patch. Setting target version to 4.1.0.

Actions #5

Updated by Marius BÄ‚LTEANU over 5 years ago

Go Maeda, lets have a basic test for this feature.

Actions #6

Updated by Mizuki ISHIKAWA over 5 years ago

I wrote a test for 20189.patch.

Actions #7

Updated by Gregor Schmidt over 5 years ago

Thank you very much for providing a test case.

Actions #8

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed the patch and test with a slight change. Thank you all for the contribution.

Actions

Also available in: Atom PDF