Patch #29189
Display custom fields on group pages
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Custom fields | |||
| Target version: | 4.0.0 |
Description
It's possible to add custom fields to groups, but they are no where displayed but in the edit view within the admin area.
The attached patch extends groups#show to also list custom fields defined for the group. It's targeted at r17428.
0001-Show-group-custom-fields-on-group-view-page.patch 
(998 Bytes)
screenshot-29189@2x.png (16.3 KB)
29189.patch
(625 Bytes)
add_test_to_29189_patch.patch
(1.3 KB)
History
#1
Updated by Go MAEDA about 3 years ago
- File screenshot-29189@2x.png added
This is a screenshot of /groups/:id page after applying the patch.
#2
Updated by Go MAEDA about 3 years ago
- Assignee set to Gregor Schmidt
Thank you for posting the patch. I think this patch improves the consistency of UI.
But I wonder whether the heading "Attributes" is necessary. /users/:id page does not add such a heading when showing custom fields (see http://www.redmine.org/users/347 for example). In addition, :label_attribute_plural is only used in app/views/auth_sources/_form_auth_source_ldap.html.erb.
Do you think we can remove "<h3><%= l(:label_attribute_plural) %></h3>" from the patch?
#3
Updated by Gregor Schmidt about 3 years ago
Thank you for reviewing this patch.
I don't have a strong opinion on this one. I've added the sub heading for cosmetic reasons. If you think it's not necessary, this is OK for me.
#4
Updated by Go MAEDA about 3 years ago
- File 29189.patch added
- Assignee deleted (
Gregor Schmidt) - Target version set to 4.1.0
I have slightly changed Gregor Schmidt's patch. Setting target version to 4.1.0.
#5
Updated by Marius BALTEANU about 3 years ago
Go Maeda, lets have a basic test for this feature.
#6
Updated by Mizuki ISHIKAWA about 3 years ago
- File add_test_to_29189_patch.patch added
I wrote a test for 20189.patch.
#7
Updated by Gregor Schmidt about 3 years ago
Thank you very much for providing a test case.
#8
Updated by Go MAEDA about 3 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from 4.1.0 to 4.0.0
Committed the patch and test with a slight change. Thank you all for the contribution.