Project

General

Profile

Actions
Copy link

Patch #29406

closed

Use sorted instead of sort

Added by Pavel Rosický over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Performance
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

using an order statement should be more effective because records are sorted in the database.

issue priorities on the issue's report page were originaly sorted by id (desc), but I think they should be sorted by position.

Files

Download all files
projects_versions.patch (1.22 KB) projects_versions.patch Pavel Rosický, 2018-08-18 14:35
files_controller.rb.patch (323 Bytes) files_controller.rb.patch Pavel Rosický, 2018-08-18 14:35
reports_controller.rb.patch (886 Bytes) reports_controller.rb.patch Pavel Rosický, 2018-08-18 14:54
reports_controller.rb.patch (1.99 KB) reports_controller.rb.patch Pavel Rosický, 2018-08-18 15:08
reports_controller.rb.patch (1.86 KB) reports_controller.rb.patch Pavel Rosický, 2018-12-01 18:12
fix-29406.diff (3.5 KB) fix-29406.diff combined Pavel Rosický's three patches Go MAEDA, 2018-12-02 02:17
Actions
Copy link
 #2

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next major release

Pavel Rosický wrote:

issue priorities on the issue's report page were originaly sorted by id (desc), but I think they should be sorted by position.

I prefer the current sort order. Showing the highest priority first is reasonable.

Actions
Copy link
 #3

Updated by Pavel Rosický over 5 years ago

issue priorities on the issue's report page were originaly sorted by id

forget about this statement. I was wrong, enumerations have a default scope, so it's already sorted and I changed the order. I reverted this change and attached a fixed version of reports_controller_patch.rb

see also related #25867 for differences between sort vs sorted, it doesn't behave the same way

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • File fix-29406.diff fix-29406.diff added
  • Category changed from Code cleanup/refactoring to Performance
  • Target version changed from Candidate for next major release to 4.1.0

Passed all tests. Setting the target version to 4.1.0.

The attached patch is a combination of Pavel Rosický's three patches.

Actions
Copy link
 #5

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for improving Redmine.

Actions
Copy link
 #6

Updated by Go MAEDA over 5 years ago

  • Subject changed from use sorted instead of sort to Use sorted instead of sort
Actions
Copy link

Also available in: Atom PDF