Redmine

Dear Redmine Team,

I experianced some test failures with the unzipped redmine-3.4.6.zip download.

The failures refer to the test cases i) attachments_visibility_test.rb and ii) unified_diff.rb.

After analysing the problems I found out that the origin of the failures is in the test files which come along with the test cases, i.e., test/fixtures/files and test/fixtures/diffs.

The unzipped version of redmine-3.4.6 has not the same files than the same redmine version checked out from repo. Some of the files in the mentioned folders have a larger size. This causes tests asking for the file size to fail as in test case i) and makes problems when running tests of test case ii). The failures of test case ii) refer to additonal carriage return characters such that \r. Therefore, the string comparison in ii) fails.

Of course for production it doesn't matter. Nevertheless, I thought you are interested in knowing about this issue.

Best Regards,

Liane Hampe

------------------------------------------------------------------------------
Environment:
Redmine version 3.4.6.stable
Ruby version 2.4.4-p296 (2018-03-28) [x86_64-linux]
Rails version 4.2.8
Environment development
Database adapter Mysql2
Database manager version Mysql 5.7.23
SCM:
Subversion 1.9.7
Git 2.17.1
Filesystem
Redmine plugins:
no plugin installed