Patch #30026
macros and textile at pdf export in custom field
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | PDF export | |||
| Target version: | Candidate for next major release |
Description
Redmine in version 3.4.6 don't fully support textile and macros in pdf export/print when custom fields be used formatted text.
I did some changes in the issue_pdf_helper.rb to do that.
issues_pdf_helper-redmine-3.4.6.rb.patch 
(4.71 KB)
issues_pdf_helper-redmine-3.4.6.rb.patch
(4.71 KB)
issues_pdf_helper-redmine-3.4.6_2sec_version.rb
(22.9 KB)
table-breaks-layout.pdf (95.5 KB)
History
#1
Updated by Dirk Rudolph over 1 year ago
- File issues_pdf_helper-redmine-3.4.6.rb.patch added
#2
Updated by Dirk Rudolph over 1 year ago
little optimizations
#3
Updated by Go MAEDA over 1 year ago
- File table-breaks-layout.pdf added
Thank you for the patch. But I noticed the following points:
- The values should be textilized only when the
text_formattingattribute for the custom field istrue. The patch always textilizes the value - Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table
#4
Updated by Dirk Rudolph over 1 year ago
Go MAEDA wrote:
- The values should be textilized only when the
text_formattingattribute for the custom field istrue. The patch always textilizes the value
No, the used function show_value() seems to check that. I tried out.
- Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table
Yes is true. The table cell becomes bigger because the height is calculated over html code in the backround. I think it's better to have a big cell and the content fits into, instead a cell that's to small. But I will trie to optimize.
#5
Updated by Dirk Rudolph over 1 year ago
- File issues_pdf_helper.rb-redmine-3.4.6_3rd.patch added
Some optimizations for the layout.
For the cell height calculation, some html-strings will remove.
#6
Updated by Dirk Rudolph over 1 year ago
- File issues_pdf_helper.rb-redmine-3.4.6_4th.patch added
Further optimizations for issues list ...