Project

General

Profile

Actions

Patch #30026

open

macros and textile at pdf export in custom field

Added by Dirk Rudolph about 5 years ago. Updated almost 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
PDF export
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Redmine in version 3.4.6 don't fully support textile and macros in pdf export/print when custom fields be used formatted text.
I did some changes in the issue_pdf_helper.rb to do that.


Files

Actions #3

Updated by Go MAEDA about 5 years ago

Thank you for the patch. But I noticed the following points:

  • The values should be textilized only when the text_formatting attribute for the custom field is true. The patch always textilizes the value
  • Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table
Actions #4

Updated by Dirk Rudolph about 5 years ago

Go MAEDA wrote:

  • The values should be textilized only when the text_formatting attribute for the custom field is true. The patch always textilizes the value

No, the used function show_value() seems to check that. I tried out.

  • Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table

Yes is true. The table cell becomes bigger because the height is calculated over html code in the backround. I think it's better to have a big cell and the content fits into, instead a cell that's to small. But I will trie to optimize.

Actions #5

Updated by Dirk Rudolph about 5 years ago

Some optimizations for the layout.
For the cell height calculation, some html-strings will remove.

Actions #7

Updated by Go MAEDA almost 5 years ago

  • Target version set to Candidate for next major release
Actions

Also available in: Atom PDF