Patch #30026
open
macros and textile at pdf export in custom field
Added by Dirk Rudolph almost 6 years ago.
Updated over 5 years ago.
Description
Redmine in version 3.4.6 don't fully support textile and macros in pdf export/print when custom fields be used formatted text.
I did some changes in the issue_pdf_helper.rb to do that.
Files
Thank you for the patch. But I noticed the following points:
- The values should be textilized only when the
text_formatting
attribute for the custom field is true
. The patch always textilizes the value
- Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table
Go MAEDA wrote:
- The values should be textilized only when the
text_formatting
attribute for the custom field is true
. The patch always textilizes the value
No, the used function show_value() seems to check that. I tried out.
- Inserting a table breaks the layout. Please see the attached pdf (table-breaks-layout.pdf). Blank lines are inserted after the table
Yes is true. The table cell becomes bigger because the height is calculated over html code in the backround. I think it's better to have a big cell and the content fits into, instead a cell that's to small. But I will trie to optimize.
Some optimizations for the layout.
For the cell height calculation, some html-strings will remove.
Further optimizations for issues list ...
- Target version set to Candidate for next major release
Also available in: Atom
PDF