Project

General

Profile

Actions
Copy link

Defect #30099

open

Multiple blank lines in pre tags are not preserved in Textile

Added by Go MAEDA almost 6 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
Go MAEDA
Category:
Text formatting
Target version:
Candidate for next major release
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

Line breaks should be rendered intact in pre blocks but consecutive line breaks are not rendered in Textile. It works as expected in Markdown.
Input:

Expected:

Actual:

Files

Download all files
screenshot-input@2x.png (8.46 KB) screenshot-input@2x.png Go MAEDA, 2018-12-05 03:53
screenshot-expected@2x.png (10.1 KB) screenshot-expected@2x.png Go MAEDA, 2018-12-05 03:53
screenshot-actual@2x.png (9.77 KB) screenshot-actual@2x.png Go MAEDA, 2018-12-05 03:53
30099.patch (1.42 KB) 30099.patch Takenori TAKAKI, 2019-02-18 05:37
30099-fixed-30987.patch (1.23 KB) 30099-fixed-30987.patch Takenori TAKAKI, 2019-03-19 09:53

Related issues

Related to Redmine - Defect #30987: Unnecessary empty lines are displayed when syntax highlightingClosed

Actions
Actions
Copy link
 #1

Updated by Takenori TAKAKI almost 6 years ago

I think that it is possible to solve the problem by swapping the order of 'escape pre content' and 'clean up white space' in RedCloth#to_html.
I made a patch and attach it.

Actions
Copy link
 #2

Updated by Go MAEDA almost 6 years ago

  • Target version set to 4.1.0

Setting the target version to 4.1.0.

Actions
Copy link
 #3

Updated by Go MAEDA almost 6 years ago

  • Subject changed from Consecutive line breaks in a pre element are not rendered in Textile to Multiple blank lines in pre tags are not preserved in Textile
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for fixing this issue.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Related to Defect #30987: Unnecessary empty lines are displayed when syntax highlighting added
Actions
Copy link
 #5

Updated by Go MAEDA over 5 years ago

  • Status changed from Closed to Reopened

This patch causes a problem reported as #30987.

I think r17891 should be reverted.

Actions
Copy link
 #6

Updated by Go MAEDA over 5 years ago

  • Status changed from Reopened to New
  • Target version deleted (4.1.0)
  • Resolution deleted (Fixed)
Actions
Copy link
 #7

Updated by Takenori TAKAKI over 5 years ago

Go MAEDA wrote:

This patch causes a problem reported as #30987.

I think r17891 should be reverted.

Sorry for the problem reported in # 30987.
I made another patch to fix this problem.
I hope it will be improvement for Redmine.

Actions
Copy link
 #8

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #9

Updated by Go MAEDA over 4 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions
Copy link
 #10

Updated by Marius BĂLTEANU over 3 years ago

  • Target version changed from 4.2.0 to 5.0.0
Actions
Copy link
 #11

Updated by Marius BĂLTEANU over 2 years ago

  • Target version changed from 5.0.0 to Candidate for next major release
Actions
Copy link

Also available in: Atom PDF