Defect #30259
URLs end with "-" are rendered incorrectly in Textile
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Text formatting | |||
| Target version: | 4.1.0 | |||
| Resolution: | Fixed | Affected version: |
Description
Last character "-" makes wrong link
please add link "-" character
for example googledrive use "-"
--
ja---
概要、説明、注記等で、ＵＲＬリンクの最後の文字が "-"だった場合
リンク扱いとならず、誤ったリンクとなる
グーグルドライブなどは、最終文字が "-" となることがあり、修正してほしいです
画像も参照してください
Associated revisions
URLs end with "-" are rendered incorrectly in Textile (#30259).
Patch by Yuichi HARADA.
History
#1
Updated by Go MAEDA over 3 years ago
- Subject changed from Last character "-" makes wrong link to URLs end with "-" are rendered incorrectly in Textile
- Description updated (diff)
- Category set to Text formatting
- Status changed from New to Confirmed
confirmed the problem. This issue is reproducible in Textile. Markdown is not affected.
Input:
http://example.com/foo-
Expected output:
<a class="external" href="http://example.com/foo-">http://example.com/foo-</a>
Actual output:
<a class="external" href="http://example.com/foo">http://example.com/foo</a>-
#2
Updated by Yuichi HARADA over 3 years ago
- File 0001-Remove-unnecessary-trailing-white-spaces.patch
added - File 0002-Interpret-trailing-hyphens-as-URL.patch added
I reviewed the regular expression to interpret the trailing hyphens as URL.
I attached patches.
#3
Updated by Go MAEDA over 3 years ago
- Target version set to Candidate for next minor release
#4
Updated by Guillermo ML over 3 years ago
- File output.trailing.special.characters.png added
Same with ?, &, # and $ characters. These URL:
https://example.org/ticket.form.php?id=333? https://example.org/ticket.form.php?id=333& https://example.org/TicketID=455# https://example.org/TicketID=455$
will be rendered (3.4.4.stable) as:
For example the second link could be generated by glpi tool and the third one is sometimes generated by otrs tool. I think all four are valid characters at the end of an URL.
#5
Updated by Go MAEDA over 3 years ago
- Target version changed from Candidate for next minor release to 4.0.2
Setting the target version to 4.0.2.
#6
Updated by Go MAEDA over 3 years ago
- Target version changed from 4.0.2 to 4.1.0
#7
Updated by Go MAEDA over 3 years ago
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you all for reporting and fixing this issue.