Defect #30431
closed
Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-member
Added by Go MAEDA over 5 years ago.
Updated almost 5 years ago.
Category:
Permissions and roles
Description
Since you cannot grant a "Delete issues" permission for Anonymous and Non-member roles, "Delete issues" column in the tracker permission table on the role page is useless. The column should be hidden like default "Reporter" role.
![](/attachments/download/22216/delete-issues-tracker-permission@2x.png)
Files
It was displayed "Delete issues" column in the tracker permission table on the role page because it was not confirmed the settable permissions of the role.
I attached a patch.
- Target version set to Candidate for next minor release
LGTM but I propose a slight change as follows. Using &
operator is simpler and much faster than using delete_if
.
<% permissions = [:view_issues, :add_issues, :edit_issues, :add_issue_notes, :delete_issues] & setable_permissions.collect(&:name) %>
Setting the target version to 4.1.0.
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for fixing this issue.
Also available in: Atom
PDF