Project

General

Profile

Actions

Defect #30923

closed

Project search should select subprojects scope when the project has subprojects

Added by Yuuki NARA about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Search engine
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

In the following tickets,
the project search has been changed by Redmine 3.4.0 to include subprojects by default,

Search in project and its subprojects by default
http://www.redmine.org/issues/9909

But it is not working as expected.
Selected the project itself.

I confirmed it in Redmine 3.4.6.


Files


Related issues

Related to Redmine - Feature #9909: Search in project and its subprojects by defaultClosedJean-Philippe Lang

Actions
Actions #1

Updated by Go MAEDA about 5 years ago

  • Related to Feature #9909: Search in project and its subprojects by default added
Actions #2

Updated by Go MAEDA about 5 years ago

I tested the behavior on the current trunk. NARA-san, are you talking about the second behavior?

  1. Redmine searches the current project and its subprojects when you enter search keywords to the box on the upper-right corner. It seems working as expected.
  2. If you click the label "Search" on the left side of the box, the default scope is the current project only.

Actions #3

Updated by Yuuki NARA about 5 years ago

Maeda-San, Thank you for pointing out.

I was doing the operation of test-2.

Even in my own environment, test-1 has Subproject, and in test-2 it has only Project itself.

In issue9909, it seems that this difference is not mentioned at all.

There are two operation methods test1 and test2.

Which is running

Was the fix that JPL committed effective only when you performed test-1 operation?

Actions #4

Updated by Go MAEDA about 5 years ago

  • Assignee deleted (Yuuki NARA)

Yuuki NARA wrote:

I was doing the operation of test-2.

Even in my own environment, test-1 has Subproject, and in test-2 it has only Project itself.

Thank you for clarifying. I think the scope drop-down which is shown by the second operation also should include subprojects, as you insist.

Actions #5

Updated by Yuuki NARA about 5 years ago

+1

The operation of the search operation should be consistent.

Actions #6

Updated by Marius BĂLTEANU about 5 years ago

  • Assignee set to Marius BĂLTEANU
Actions #7

Updated by Marius BĂLTEANU about 5 years ago

Attach the patch with the fix and tests for this issue and also for #9909.

I think we can deliver this small change in 3.4.10.

Actions #8

Updated by Go MAEDA about 5 years ago

  • Subject changed from Project search does not select subproject by default to Project search should select subprojects scope when the project has subprojects
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing the issue.

Actions #9

Updated by Go MAEDA about 5 years ago

  • Status changed from Confirmed to Resolved
Actions #10

Updated by Go MAEDA about 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF