Patch #31035
Remove the workaround for #12090
Status: | New | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Code cleanup/refactoring | |||
Target version: | Candidate for next major release |
Description
If the patch #30820 that drops "Blind carbon copy recipients (bcc)" setting is accepted, we can remove the workaround for #12090 that fixes the issue that email recipients are not logged when the setting is enabled, because emails will always be sent using To.
diff --git a/config/initializers/10-patches.rb b/config/initializers/10-patches.rb
index e0559903b..a42b91e4c 100644
--- a/config/initializers/10-patches.rb
+++ b/config/initializers/10-patches.rb
@@ -122,24 +122,6 @@ end
ActionMailer::Base.add_delivery_method :tmp_file, DeliveryMethods::TmpFile
-# Changes how sent emails are logged
-# Rails doesn't log cc and bcc which is misleading when using bcc only (#12090)
-module ActionMailer
- class LogSubscriber < ActiveSupport::LogSubscriber
- def deliver(event)
- recipients = [:to, :cc, :bcc].inject(+"") do |s, header|
- r = Array.wrap(event.payload[header])
- if r.any?
- s << "\n #{header}: #{r.join(', ')}"
- end
- s
- end
- info("\nSent email \"#{event.payload[:subject]}\" (%1.fms)#{recipients}" % event.duration)
- debug(event.payload[:mail])
- end
- end
-end
-
module ActionController
module MimeResponds
class Collector
Related issues
History
#1
Updated by Go MAEDA about 2 years ago
- Blocked by Patch #30820: Drop setting "Blind carbon copy recipients (bcc)" added