Patch #30820

Drop setting "Blind carbon copy recipients (bcc)"

Added by Marius BALTEANU over 2 years ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Email notifications
Target version:5.0.0

Description

From #26791:

BCC recipients

Since each user gets their own mail, we can probably remove the setting to send mails with BCC completely. If plugins want to send mails to non-user recipients, we would have to make sure to either set the recipients manually on BCC or group them appropriately. It is not a required setting in Redmine core anymore though.

I agree, the setting doesn't make any sense now.

0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch Magnifier (23.8 KB) Marius BALTEANU, 2019-02-20 09:55

0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch Magnifier (25.9 KB) Marius BALTEANU, 2021-04-11 10:16

Related issues

Related to Redmine - Feature #26791: Send individual notification mails per mail recipient Closed
Related to Redmine - Defect #30787: Other recipients are not listed in To field even if Setti... Closed
Related to Redmine - Feature #8516: Email notifications without the recipient treated as atte... Closed 2011-06-03
Related to Redmine - Defect #35957: MessagesControllerTest#test_post_new test fails (trunk) Closed
Blocks Redmine - Patch #31035: Remove redefinition of ActionMailer::LogSubscriber#delive... Closed

Associated revisions

Revision 21130
Added by Marius BALTEANU 3 months ago

Remove unused setting 'Blind carbon copy recipients (bcc)' (#30820).

Revision 21131
Added by Marius BALTEANU 3 months ago

Remove 'setting_bcc_recipients' from locales (##30820).

History

#1 Updated by Marius BALTEANU over 2 years ago

  • Related to Feature #26791: Send individual notification mails per mail recipient added

#2 Updated by Marius BALTEANU over 2 years ago

  • Related to Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false added

#3 Updated by Go MAEDA over 2 years ago

  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 4.0.2

+1
The setting has no effect since #26791 was implemented.

#4 Updated by Go MAEDA over 2 years ago

Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.

#5 Updated by Go MAEDA over 2 years ago

  • Related to Feature #8516: Email notifications without the recipient treated as attempted fraud by mail clients added

#6 Updated by Marius BALTEANU over 2 years ago

Go MAEDA wrote:

Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.

Agree. Also, #30787 can be closed now from my point of view if you don't refer to other problem.

#7 Updated by Marius BALTEANU over 2 years ago

  • File deleted (0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch)

#8 Updated by Marius BALTEANU over 2 years ago

Updated to remove bcc_recipients from settings.yml as well.

#9 Updated by Go MAEDA over 2 years ago

  • Category set to Email notifications
  • Target version changed from 4.0.2 to 4.1.0

Since this patch adds a migration, I am changing the target version from 4.0.2 to 4.1.0.

#10 Updated by Go MAEDA over 2 years ago

  • Blocks Patch #31035: Remove redefinition of ActionMailer::LogSubscriber#deliver which is no longer necessary because of the removal of Setting.bcc_recipients added

#11 Updated by Jean-Philippe Lang over 2 years ago

  • Target version changed from 4.1.0 to 5.0.0

Removing a setting may cause some plugins to error.
Setting it to a major release.

#12 Updated by Marius BALTEANU 7 months ago

  • Assignee changed from Jean-Philippe Lang to Marius BALTEANU

#13 Updated by Marius BALTEANU 6 months ago

I've rebased the branch for the current trunk

#14 Updated by Marius BALTEANU 6 months ago

Marius BALTEANU wrote:

I've rebased the patch for the current trunk

#15 Updated by Holger Just 6 months ago

If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.

That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)

#16 Updated by Marius BALTEANU 4 months ago

Holger Just wrote:

If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.

That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)

The next version is 5.0.0 which will contain other removals or breaking changes. I'm in favour of removing this and in the future, indeed, we can deprecate it few versions before.

#17 Updated by Marius BALTEANU 3 months ago

  • Status changed from New to Resolved

#18 Updated by Marius BALTEANU 3 months ago

Patch committed.

Plugins developers who are using bcc_recipients setting must add their own setting starting from Redmine 5.0.0.

#19 Updated by Marius BALTEANU 3 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marius BALTEANU

#20 Updated by Go MAEDA 13 days ago

  • Related to Defect #35957: MessagesControllerTest#test_post_new test fails (trunk) added

Also available in: Atom PDF