Feature #30820
closed
Drop setting "Blind carbon copy recipients (bcc)"
0%
Description
From #26791:
BCC recipients¶
Since each user gets their own mail, we can probably remove the setting to send mails with BCC completely. If plugins want to send mails to non-user recipients, we would have to make sure to either set the recipients manually on BCC or group them appropriately. It is not a required setting in Redmine core anymore though.
I agree, the setting doesn't make any sense now.
Files
Related issues
Updated by Marius BALTEANU over 4 years ago
- Related to Feature #26791: Send individual notification mails per mail recipient added
Updated by Marius BALTEANU over 4 years ago
- Related to Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false added
Updated by Go MAEDA over 4 years ago
- Assignee set to Jean-Philippe Lang
- Target version changed from Candidate for next major release to 4.0.2
+1
The setting has no effect since #26791 was implemented.
Updated by Go MAEDA over 4 years ago
Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.
Updated by Go MAEDA over 4 years ago
- Related to Feature #8516: Email notifications without the recipient treated as attempted fraud by mail clients added
Updated by Marius BALTEANU over 4 years ago
Updated by Marius BALTEANU over 4 years ago
- File deleted (
0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch)
Updated by Marius BALTEANU over 4 years ago
- File 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch added
Updated to remove bcc_recipients from settings.yml as well.
Updated by Go MAEDA over 4 years ago
- Category set to Email notifications
- Target version changed from 4.0.2 to 4.1.0
Since this patch adds a migration, I am changing the target version from 4.0.2 to 4.1.0.
Updated by Go MAEDA over 4 years ago
- Blocks Patch #31035: Remove redefinition of ActionMailer::LogSubscriber#deliver which is no longer necessary because of the removal of Setting.bcc_recipients added
Updated by Jean-Philippe Lang over 4 years ago
- Target version changed from 4.1.0 to 5.0.0
Removing a setting may cause some plugins to error.
Setting it to a major release.
Updated by Marius BALTEANU over 2 years ago
- Assignee changed from Jean-Philippe Lang to Marius BALTEANU
Updated by Marius BALTEANU over 2 years ago
- File 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch added
- Assignee deleted (
Marius BALTEANU)
I've rebased the branch for the current trunk
Updated by Marius BALTEANU over 2 years ago
Marius BALTEANU wrote:
I've rebased the patch for the current trunk
Updated by Holger Just over 2 years ago
If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.
That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)
Updated by Marius BALTEANU about 2 years ago
Holger Just wrote:
If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.
That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)
The next version is 5.0.0 which will contain other removals or breaking changes. I'm in favour of removing this and in the future, indeed, we can deprecate it few versions before.
Updated by Marius BALTEANU about 2 years ago
- Status changed from New to Resolved
Updated by Marius BALTEANU about 2 years ago
Patch committed.
Plugins developers who are using bcc_recipients setting must add their own setting starting from Redmine 5.0.0.
Updated by Marius BALTEANU about 2 years ago
- Status changed from Resolved to Closed
- Assignee set to Marius BALTEANU
Updated by Go MAEDA almost 2 years ago
- Related to Defect #35957: MessagesControllerTest#test_post_new test fails (trunk) added