Project

General

Profile

Actions

Defect #31132

closed

Remove unused column trackers.is_in_chlog

Added by Go MAEDA almost 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The column "is_in_chlog" in "trackers" table can be removed safely. It was used to control former Changelog view which has been dropped in r3162 (Redmine 0.9.0). After that, the column is no longer used.

$ grep -r is_in_chlog *
db/migrate/20180923091603_change_sqlite_booleans_default.rb:      "is_in_chlog" => false,
db/migrate/001_setup.rb:      t.column "is_in_chlog", :boolean, :default => false, :null => false
db/migrate/20180923082945_change_sqlite_booleans_to_0_and_1.rb:    Tracker => ['is_in_chlog', 'is_in_roadmap'],
lib/redmine/default_data/loader.rb:            Tracker.create!(:name => l(:default_tracker_bug),     :default_status_id => new.id, :is_in_chlog => true,  :is_in_roadmap => false, :position => 1)
lib/redmine/default_data/loader.rb:            Tracker.create!(:name => l(:default_tracker_feature), :default_status_id => new.id, :is_in_chlog => true,  :is_in_roadmap => true,  :position => 2)
lib/redmine/default_data/loader.rb:            Tracker.create!(:name => l(:default_tracker_support), :default_status_id => new.id, :is_in_chlog => false, :is_in_roadmap => false, :position => 3)
test/fixtures/trackers.yml:  is_in_chlog: true
test/fixtures/trackers.yml:  is_in_chlog: true
test/fixtures/trackers.yml:  is_in_chlog: false

Files

Actions #1

Updated by Go MAEDA over 4 years ago

  • Assignee set to Jean-Philippe Lang
  • Target version set to 4.1.0
Actions #2

Updated by Go MAEDA over 4 years ago

  • Target version changed from 4.1.0 to 4.2.0
Actions #3

Updated by Marius BĂLTEANU almost 3 years ago

  • Target version changed from 4.2.0 to 5.0.0
Actions #5

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed

Committed with a slight change: the down method adds back the column in order to allow a rollback.

Actions

Also available in: Atom PDF