Project

General

Profile

Actions

Patch #31433

closed

Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions

Added by Marius BĂLTEANU almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Files


Related issues

Related to Redmine - Patch #24313: Use the regular "icon icon-*" classes for all elements with iconsClosedJean-Philippe Lang

Actions
Related to Redmine - Patch #28605: Add the missing icon class to the items with icons from the contextual menuClosedGo MAEDA

Actions
Related to Redmine - Defect #31496: Switch between toggle plus and minus icons for toggle multi selectClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Target version set to 4.1.0
Actions #2

Updated by Go MAEDA almost 5 years ago

  • Assignee set to Marius BĂLTEANU

Could you write the intention of this change?

Actions #3

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Patch #24313: Use the regular "icon icon-*" classes for all elements with icons added
Actions #4

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Patch #28605: Add the missing icon class to the items with icons from the contextual menu added
Actions #5

Updated by Marius BĂLTEANU almost 5 years ago

Go MAEDA wrote:

Could you write the intention of this change?

Yes, it is the same as #24313 or #28605.

Actions #6

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Closed
  • Assignee changed from Marius BĂLTEANU to Go MAEDA

Committed the patch. Thanks.

Actions #7

Updated by Marius BĂLTEANU almost 5 years ago

  • Status changed from Closed to Reopened
  • Assignee changed from Go MAEDA to Marius BĂLTEANU

I broke something, I'll add a patch to fix it later.

Actions #9

Updated by Go MAEDA almost 5 years ago

  • Status changed from Reopened to Closed
  • Assignee changed from Marius BĂLTEANU to Go MAEDA

Marius BALTEANU wrote:

Here are three more patches:
- 0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- 0002-Use-icon-icon-classes-for-expandable-elements.patch and 0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.

Committed the patches. Thanks.

Actions #10

Updated by Marius BĂLTEANU almost 5 years ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Here are three more patches:
- 0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- 0002-Use-icon-icon-classes-for-expandable-elements.patch and 0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.

Committed the patches. Thanks.

Thanks! I'll take a look again to check if it's everything ok.

Actions #11

Updated by Marius BĂLTEANU over 4 years ago

  • Related to Defect #31496: Switch between toggle plus and minus icons for toggle multi select added
Actions #12

Updated by Yuichi HARADA over 4 years ago

Collapsed/Expanded of filters and options in "Issues list, Spent time, Gantt, Calendar" do not worked using for IE11.
I think that maybe the toggleClass is the cause.
source:trunk/public/javascripts/application.js@18204#L75

Actions #13

Updated by Go MAEDA over 4 years ago

  • Status changed from Closed to Reopened
Actions #14

Updated by Marius BĂLTEANU over 4 years ago

  • Assignee changed from Go MAEDA to Marius BĂLTEANU
Actions #15

Updated by Marius BĂLTEANU over 4 years ago

  • Status changed from Reopened to Closed
  • Assignee changed from Marius BĂLTEANU to Go MAEDA

The problem is caused by #3058 and it'll be fixed by the patch from #3058#note-96.

Actions #16

Updated by Marius BĂLTEANU over 4 years ago

I've just found 2 small issues where the expander icon is missing.

Project list:

Permissions report:

Attached the fix.

Actions #17

Updated by Go MAEDA over 4 years ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

I've just found 2 small issues where the expander icon is missing.

Confirmed the issues and committed the patch in r18897. Thanks.

Actions

Also available in: Atom PDF