Defect #31438
closed
Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
0%
Description
Hi all,
I noticed that the associated revisions block is not places next to the comments section as it used to be. This happens when a user selects to display comments - In reverse chronological order option in /my/account. If it is set up to be displayed in chronological order everything looks just fine. I've attached a screenshot with shows the issue (this is the Purplemine theme here but it happen with the original one too).
mrliptontea from the Purplemine project found the root cause for this and wrote the following:
Aha! I found the cause - this happens when a user selects Display comments - In reverse chronological order option in /my/account. The same layout issue then happens with the default theme. This is because with reversed order the contextual menu is also displayed above the comment history, as defined in the template. Sorry but I'm afraid I can't fix this.
He marked the possible issue inside the redmine source code here.
Files
Related issues
Updated by Go MAEDA over 5 years ago
- Status changed from New to Closed
- Resolution set to Invalid
Since the problem occurs only in the third-party theme, there is nothing we can do.
I hope the theme developer suggests how to update the Redmine's code to fix their issue.
Updated by Mathias Buder over 5 years ago
- File 2019-05-26 14_59_33-Window.png 2019-05-26 14_59_33-Window.png added
- Status changed from Closed to Reopened
Hi,
thanks for the quick replay.
As I've wrote in the description is happens also with the default Redmine theme. See attached screenshot.
Mathias Buder wrote:
Hi all,
I noticed that the associated revisions block is not places next to the comments section as it used to be. This happens when a user selects to display comments - In reverse chronological order option in /my/account. If it is set up to be displayed in chronological order everything looks just fine. I've attached a screenshot with shows the issue (this is the Purplemine theme here but it happen with the original one too).
Updated by Go MAEDA over 5 years ago
- Resolution deleted (
Invalid)
I think it will be fixed if #3058 is merged to the trunk.
Updated by Go MAEDA over 5 years ago
- Related to Feature #3058: Show issue history using tabs added
Updated by Go MAEDA over 5 years ago
- File fix-31438.diff fix-31438.diff added
- File 31438-before@2x.png 31438-before@2x.png added
- File 31438-after@2x.png 31438-after@2x.png added
- Status changed from Reopened to Confirmed
- Target version set to Candidate for next minor release
I think the attached patch fixes the issue.
[Before]
[After]
Updated by Go MAEDA over 5 years ago
- Related to Feature #23518: Move action links and edit form above the history when displaying comments in reverse order added
Updated by Go MAEDA over 5 years ago
- Target version changed from Candidate for next minor release to 4.0.4
Updated by Go MAEDA over 5 years ago
- Subject changed from Associated revisions block not places next to history to Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
Committed the fix. Thank you for reporting this issue.
Updated by Go MAEDA over 5 years ago
- Status changed from Resolved to Closed
- Resolution set to Fixed
Updated by Tomas Hubik about 5 years ago
I am using Redmine 4.0.5 and I am still facing this issue.
Updated by Bernhard Rohloff about 5 years ago
- Related to Patch #32370: Action menu on issues details should not flip with the history order added