Project

General

Profile

Actions

Defect #31503

closed

Undefined local variable sender_email in MailHandler#receive_message_reply

Added by Andriy Lesyuk over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Email receiving
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When receiving a reply to a locked topic, mail handler crashes with the following error:

  undefined local variable or method `sender_email' for #<MailHandler:0x0055675dfa9e10>
Did you mean?  send_action
  app/models/mail_handler.rb:289:in `receive_message_reply'

That's because receive_message_reply is trying to use sender_email variable, which was not defined in this method.
Here is the corresponding line (source:trunk/app/models/mail_handler.rb@18198#L277):

logger&.info "MailHandler: ignoring reply from [#{sender_email}] to a locked topic" 

Files

fix-31503-trunk.diff (1.22 KB) fix-31503-trunk.diff patch for the trunk Go MAEDA, 2019-06-09 14:07
fix-31503-3_4.diff (1.21 KB) fix-31503-3_4.diff patch for 3.4-stable and 4.0-stable Go MAEDA, 2019-06-09 14:07
Actions

Also available in: Atom PDF