Redmine

Same fail with 3.4.1: https://gitlab.com/redmine-org/redmine/-/jobs/230187783

This is due to the change https://github.com/rouge-ruby/rouge/pull/1165/. Rouge changed the CSS class for quotation marks in 3.4.0, so we can simply update the test.

By the way, how about delivering this in 4.1.0 instead of 4.2.0?

Setting the target version to 4.1.0.

Committed the patch. Thanks.

Rouge 3.5.1 has been released on July 25th.

It passed all the tests. I think we can update Rouge to 3.5.1.

diff --git a/Gemfile b/Gemfile
index ecd3bd150..4b7350e40 100644
--- a/Gemfile
+++ b/Gemfile
@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 gem "bundler", ">= 1.5.0" 

 gem "rails", "5.2.3" 
-gem "rouge", "~> 3.4.1" 
+gem "rouge", "~> 3.5.1" 
 gem "request_store", "1.0.5" 
 gem "mini_mime", "~> 1.0.1" 
 gem "actionpack-xml_parser" 

Updated Rouge to 3.5.1 in r18319.

Rouge 3.6.0 and 3.7.0 Changelog: https://github.com/rouge-ruby/rouge/blob/master/README.md

Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/74619202

Marius BALTEANU wrote:

Rouge 3.6.0 and 3.7.0 Changelog: https://github.com/rouge-ruby/rouge/blob/master/README.md

Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/74619202

Committed the patch. Thanks.

Rouge 3.8.0 has been released on 2019-08-07.
https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md#version-380-2019-08-07

diff --git a/Gemfile b/Gemfile
index 4dc35ee83..e7ba3f4ae 100644
--- a/Gemfile
+++ b/Gemfile
@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 gem "bundler", ">= 1.5.0" 

 gem "rails", "5.2.3" 
-gem "rouge", "~> 3.7.0" 
+gem "rouge", "~> 3.8.0" 
 gem "request_store", "1.0.5" 
 gem "mini_mime", "~> 1.0.1" 
 gem "actionpack-xml_parser" 
diff --git a/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb b/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
index 16387966c..7df35ca64 100644
--- a/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
+++ b/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
@@ -24,7 +24,7 @@ class Redmine::SyntaxHighlighting::RougeTest < ActiveSupport::TestCase
     to_test = {
       'application.js' => true,
       'Gemfile' => true,
-      'AUTOEXEC.BAT' => false,  # Rouge does not support BAT files
+      'HELLO.CBL' => false,   # Rouge does not support COBOL
       'HELLO.C' => true
     }
     to_test.each do |filename, expected|

Updated Rouge to 3.8.0 in r18369.

Updated Rouge to 3.9.0 in r18382.

Updated Rouge to 3.11.0 in r18482.

Updated Rouge to 3.12.0 in r18710.