Project

General

Profile

Actions

Defect #31870

closed

Remove deprecated .zIndex() method

Added by Fabrice Helmbacher over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Système : Debian 10
Redmine version : 4.0.1-2
libjs-jquery-ui version : 1.12.1+dfsg-5

.zIndex() method is deprecated from jQuery UI
https://jqueryui.com/upgrade-guide/1.12/#removed-zindex

.zIndex() is used in public/javascript/application.js
https://www.redmine.org/projects/redmine/repository/entry/branches/4.0-stable/public/javascripts/application.js
lines 429, 439

problem occurs when adding member to a project.

proposed correction :

function showModal(id, width, title) {
  var el = $('#'+id).first();
  if (el.length === 0 || el.is(':visible')) {return;}
  if (!title) title = el.find('h3.title').text();
  // moves existing modals behind the transparent background
-  $(".modal").zIndex(99);
+  $(".modal").css('zIndex',99);
  el.dialog({
    width: width,
    modal: true,
    resizable: false,
    dialogClass: 'modal',
    title: title
  }).on('dialogclose', function(){
-    $(".modal").zIndex(101);
+    $(".modal").css('zIndex',101);
  });
  el.find("input[type=text], input[type=submit]").first().focus();
}

Related issues

Related to Redmine - Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate libraryClosedGo MAEDA

Actions
Related to Redmine - Defect #31708: Not able to add member to a projectClosed

Actions
Blocks Redmine - Feature #31887: Update jQuery UI to 1.12.1ClosedGo MAEDA

Actions
Actions #2

Updated by Go MAEDA over 4 years ago

  • Related to Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library added
Actions #3

Updated by Marius BĂLTEANU over 4 years ago

Actions #4

Updated by Marius BĂLTEANU over 4 years ago

Actions #5

Updated by Marius BĂLTEANU over 4 years ago

Actions #6

Updated by Go MAEDA over 4 years ago

  • Category changed from Third-party libraries to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next minor release to 4.1.0
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions #7

Updated by Go MAEDA over 4 years ago

  • Subject changed from jQuery / zIndex deprecated to Remove deprecated .zIndex() method
Actions #8

Updated by Go MAEDA over 4 years ago

  • Related to Defect #31708: Not able to add member to a project added
Actions #9

Updated by Go MAEDA over 4 years ago

  • Target version changed from 4.1.0 to 4.0.5
Actions #10

Updated by Paweł Szmigiel over 4 years ago

Hi, already asked this in Defect #31708, there is a "close" text on the close button, any way to remove it? Appreciate any answer.

Actions

Also available in: Atom PDF