Feature #31887

Update jQuery UI to 1.12.1

Added by Marius BALTEANU 12 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.2.0
Resolution:Fixed

Description

We should upgrade jQuery UI to latest version (currently 1.12.1).

Upgrade guide: https://jqueryui.com/upgrade-guide/1.12/

datepicker.png (49 KB) Marius BALTEANU, 2020-05-02 21:41

overlay.png (325 KB) Marius BALTEANU, 2020-05-02 21:41

autocomplete.png (48 KB) Marius BALTEANU, 2020-05-02 21:41

0001-Update-JQuery-UI-to-1.12.1.patch.zip (281 KB) Marius BALTEANU, 2020-05-02 21:49

ScreenShot-2020-05-14-11.21.34.png (55.3 KB) Mizuki ISHIKAWA, 2020-05-14 04:35

0002-Fix-JS-languages-menu-style.patch Magnifier (1.74 KB) Marius BALTEANU, 2020-05-16 14:48


Related issues

Blocked by Redmine - Defect #31870: Remove deprecated .zIndex() method Closed
Blocks Redmine - Defect #32125: Issues autocomplete may not find issues with a subject lo... Closed

Associated revisions

Revision 19769
Added by Go MAEDA 3 months ago

Update jQuery UI to 1.12.1 (#31887).

Patch by Marius BALTEANU.

Revision 19776
Added by Go MAEDA 3 months ago

Reverts r19769 (#31887).

The change broke the Highlighted code button in the Wiki toolbar.

Revision 19783
Added by Go MAEDA 3 months ago

Update jQuery UI to 1.12.1 (#31887).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU 12 months ago

  • Related to Defect #31870: Remove deprecated .zIndex() method added

#2 Updated by Marius BALTEANU 12 months ago

  • Related to deleted (Defect #31870: Remove deprecated .zIndex() method)

#3 Updated by Marius BALTEANU 12 months ago

  • Blocked by Defect #31870: Remove deprecated .zIndex() method added

#4 Updated by Sho HASHIMOTO 12 months ago

+1!!

#5 Updated by Sho HASHIMOTO 12 months ago

note: jQuery 1.x and 2.x was already EOL. See below.

#6 Updated by Marius BALTEANU 3 months ago

  • File 0001-Update-JQuery-UI-to-1.12.1.patch.zip added
  • Target version set to Candidate for next major release

Here is a patch that updates jQuery UI to latest version (1.12.1). The patch is zip archive because of the size.

Among all the changes, the new version of jQuery UI brings a new default theme (Smoothness) and Font size changes which do not require anymore some overrides made in Redmine theme.

Beside the update, the patch removes those overrides, adds a new overlay background and makes the autocomplete to have the same look and feel from inline auto complete, context menu or quick project.

Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.

#7 Updated by Marius BALTEANU 3 months ago

Some screenshots.

#8 Updated by Marius BALTEANU 3 months ago

  • File deleted (0001-Update-JQuery-UI-to-1.12.1.patch.zip)

#10 Updated by Marius BALTEANU 3 months ago

Sho HASHIMOTO wrote:

note: jQuery 1.x and 2.x was already EOL. See below.

Here we track jQuery UI update and in #33383 we track jQuery.

#11 Updated by Go MAEDA 3 months ago

Marius BALTEANU wrote:

Here is a patch that updates jQuery UI to latest version (1.12.1). The patch is zip archive because of the size.

Thank you for working on this. Features that depend on JQuery UI such as dialogs and auto-completes seem to be working fine.

#12 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#13 Updated by Go MAEDA 3 months ago

Marius BALTEANU wrote:

Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.

Dropping some components is a big change, so I think it is better to put off the change until Redmine 5.0.

#14 Updated by Marius BALTEANU 3 months ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.

Dropping some components is a big change, so I think it is better to put off the change until Redmine 5.0.

Agree.

#15 Updated by Go MAEDA 3 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

#16 Updated by Mizuki ISHIKAWA 3 months ago

The style of the highlighted code listings on the Wiki toolbar has changed since this change was committed.
The background color of the li element does not change when hovering.

#17 Updated by Go MAEDA 3 months ago

  • Status changed from Closed to Reopened

#18 Updated by Go MAEDA 3 months ago

  • Blocks Defect #32125: Issues autocomplete may not find issues with a subject longer than 60 characters added

#19 Updated by Go MAEDA 3 months ago

Mizuki ISHIKAWA wrote:

The style of the highlighted code listings on the Wiki toolbar has changed since this change was committed.
The background color of the li element does not change when hovering.

Reverted r19769 in r19776.

#20 Updated by Marius BALTEANU 3 months ago

  • Assignee changed from Go MAEDA to Marius BALTEANU

#21 Updated by Marius BALTEANU 3 months ago

Here is the patch to fix the reported issue, thanks for pointing this out. I didn't know that the JS Toolbar depends on the menu component from jQuery UI (issue cause). We should drop this dependency in the future.

@Go Maeda, I don't think that it's necessary to revert the changes, we're on trunk and for the patches that I work on, I will provide fixes as soon as I can.

#22 Updated by Go MAEDA 3 months ago

  • Status changed from Reopened to Closed

Committed the patch again with 0002-Fix-JS-languages-menu-style.patch. Thank you.

@Go Maeda, I don't think that it's necessary to revert the changes, we're on trunk and for the patches that I work on, I will provide fixes as soon as I can.

I thought it was a rather serious issue. And I didn't expect the issue is fixed so quickly. But now I think that reverting r19769 was too early.

Also available in: Atom PDF