Patch #32013
closed
Rounded corners of the main menu
Added by Anonymous about 5 years ago. Updated about 5 years ago.
Description
Most UI elements of Redmine are now rounded, it feels like main menu should too.
Files
| rounded-main-menu-corners.patch (1021 Bytes) rounded-main-menu-corners.patch | Anonymous, 2019-09-04 18:52 | ||
| roundedmenu.png (20.4 KB) roundedmenu.png | Anonymous, 2019-09-04 19:33 | ||
| menu-children-border-radius.png (5.75 KB) menu-children-border-radius.png | Bernhard Rohloff, 2019-09-23 06:51 | ||
| fixed-menu-children-border-radius.diff (1.51 KB) fixed-menu-children-border-radius.diff | Bernhard Rohloff, 2019-09-23 06:51 |
Related issues
Updated by Bernhard Rohloff about 5 years ago
- Related to Patch #32015: Rounded corners of "my page" blocks added
Updated by Bernhard Rohloff about 5 years ago
+1 IMHO it looks very nice and polished. It fits nicely into the design of the other tab menus.
Updated by Bernhard Rohloff about 5 years ago
- Related to Patch #32014: Rounded corners on table.list elements added
Updated by Bernhard Rohloff about 5 years ago
- Related to Patch #32016: Rounded coreners on roadmap's progress bar added
Updated by Go MAEDA about 5 years ago
- Target version set to 4.1.0
LGTM. Setting the target version to 4.1.0.
Bernhard Rohloff wrote:
It fits nicely into the design of the other tab menus.
Indeed. Tabs in the project settings page and the administration page already have rounded corner. Tabs in the project menu should have rounded corner as well in order to make the appearance consistent.
Updated by Go MAEDA about 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you for the nice improvement.
Updated by Bernhard Rohloff about 5 years ago
- File menu-children-border-radius.png menu-children-border-radius.png added
- File fixed-menu-children-border-radius.diff fixed-menu-children-border-radius.diff added
- Status changed from Closed to Reopened
I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.
Updated by Anonymous about 5 years ago
Bernhard Rohloff wrote:
I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.
Thanks for the heads up, I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D
I think we should add #32100 as related to this ticket.
Updated by Bernhard Rohloff about 5 years ago
- Related to Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements added
Updated by Bernhard Rohloff about 5 years ago
Antonio McDeal wrote:
... I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D
Oh sorry, I didn't noticed that...
I think we should add #32100 as related to this ticket.
done ;-)
Updated by Anonymous about 5 years ago
Go, would it be possible to commit Bernhard's fix? I tested it, works well ;-)
Updated by Go MAEDA about 5 years ago
- Status changed from Reopened to Closed
Bernhard Rohloff wrote:
I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too.
Committed the fix fixed-menu-children-border-radius.diff in r18543. Thanks.