Patch #32054
closed
Add test for 4 byte characters (emoji) support
Added by Marius BĂLTEANU about 5 years ago.
Updated over 3 years ago.
Category:
Code cleanup/refactoring
Description
In #31921 was added proper support for 4 byte characters (emoji) for new installations with MySQL as database.
I proposed to have a test for this case, but we're worried that the test will broke the CI server.
The scope of this ticket is to fix the CI server if the MySQL is not already configured properly by recreating the database with utf8mb4 encoding.
Files
- Related to Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL added
- Target version changed from 4.1.0 to 4.2.0
Marius BALTEANU wrote:
I proposed to have a test for this case, but we're worried that the test will broke the CI server.
I think we can avoid errors occurring on the CI server by adding the following check at the beginning of the test.
skip if Redmine::Database.mysql? && !is_mysql_utf8mb4
I will commit test_for_emoji_support-v2.patch soon.
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you.
Also available in: Atom
PDF