Defect #32063
closed
'use strict' in inlineAutoComplete causes error on Poltergeist
Added by Tatsuya Saito over 4 years ago.
Updated over 4 years ago.
Description
'use strict' in inlineAutoComplete causes error on Poltergeist.
r18444 with #31989 implemented inlineAutoComplete method in application.js.
After that, integration tests of my plugin have following errors.
Error:
Capybara::Poltergeist::JavascriptError: One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
I attach a patch to fix it.
Files
I am not good at JavaScript, so I am not sure why the code in the core should be changed in order to fix the error raised in a plugin. Is the code added in r18444 wrong?
- Assignee set to Marius BĂLTEANU
I understand. Thank you for the explanation.
Marius, please check the attached patch. Is it OK with you?
- Status changed from New to Needs feedback
- Assignee changed from Marius BĂLTEANU to Tatsuya Saito
I don’t think we should write old JS syntax only to make the code compatible with PhantomJS which is no longer under active development. Also, Redmine is using Selenium with Chrome driver for system tests starting with version 4.
Regarding old browsers, I would be very happy to change the code if is not compatible with an old browser which is still supported by Redmine. Do you know one? From my tests, there is no problem in IE11.
Marius BALTEANU,
Thank you for explanation, and I agree your opinion.
I don't know other browser with the problem. I think this issue shall be rejected.
- Status changed from Needs feedback to Closed
- Resolution set to Wont fix
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by