Defect #32153
Repository browser does not render previews for audio/video files
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed | Affected version: |
Description
#27336 added preview for audio/video files to attachments and repositories, however, audio/video preview for repositories is not working. It always shows "No preview available" message for all kind of audio/video files.
Related issues
Associated revisions
Repository browser does not render previews for audio/video files (#32153).
Patch by Mizuki ISHIKAWA.
History
#1
Updated by Go MAEDA over 1 year ago
- Related to Patch #27336: Render previews for audio and video files added
#2
Updated by Go MAEDA over 1 year ago
- File 32153-workaround.patch
added
Attaching a quick-and-dirty workaround.
#3 Updated by Anonymous over 1 year ago
Go MAEDA wrote:
Attaching a quick-and-dirty workaround.
Thanks :-)
I'll share more feedback after I test it if I'll find more bugs
#4 Updated by Anonymous over 1 year ago
Update: this seems to be working with no problems so far, if somebody else could double check it for security sake, it would be a really cool fix to commit ;-)
#5
Updated by Go MAEDA over 1 year ago
- Target version set to Candidate for next major release
#6
Updated by Mizuki ISHIKAWA about 1 year ago
- File 0002-Add-test.patch added
If you need tests to commit 32153-workaround.patch, add tests based on the attached patch.
- 0002-Add-test.patch is a patch that should be applied after 32153-workaround.patch is applied
- 0002-Add-test.patch adds a .mp4 file to the test subversion_repository.
- rake test:scm:update command must be executed after applying the patch for the test to succeed
#7
Updated by Go MAEDA about 1 year ago
- Target version changed from Candidate for next major release to 4.1.1
Mizuki ISHIKAWA wrote:
If you need tests to commit 32153-workaround.patch, add tests based on the attached patch.
Thanks. Setting the target version to 4.1.1.
#8
Updated by Go MAEDA about 1 year ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
#9
Updated by Go MAEDA about 1 year ago
- Status changed from Resolved to Closed
- Target version changed from 4.1.1 to 4.2.0