Project

General

Profile

Actions

Feature #32764

closed

Make form validation errors more obvious for users

Added by Marius BĂLTEANU almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Currently, the validation errors are shown only on top of the page:

which makes very hard for the user to find those fields with errors, especially when there are multiple fields (how is in the case of an issue).

What do you think if we make those fields with errors more obvious?


Files

validation_errors.png (198 KB) validation_errors.png Marius BĂLTEANU, 2020-01-07 23:19
highlight_fields.png (180 KB) highlight_fields.png Marius BĂLTEANU, 2020-01-07 23:25
0001-Highlight-fields-with-validation-error.patch (738 Bytes) 0001-Highlight-fields-with-validation-error.patch Marius BĂLTEANU, 2020-01-27 00:57

Related issues

Related to Redmine - Defect #34580: Custom field labels do not contain class "error" when the field value is invalidClosed

Actions
Actions #1

Updated by Marius BĂLTEANU almost 5 years ago

  • Description updated (diff)
Actions #2

Updated by Go MAEDA almost 5 years ago

Marius BALTEANU wrote:

What do you think if we make those fields with errors more obvious?

+1
It is a very common interface. And the issue form tends to have many fields, so Redmine should definitely have this feature.

Actions #3

Updated by Mischa The Evil almost 5 years ago

Marius BALTEANU wrote:

What do you think if we make those fields with errors more obvious?

I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the actual field (border) itself is sufficient. We might want to get some feedback on that as some users may have patched/changed the core in such a way that it has custom field styling which may conflict with such a change (however, such shouldn't block a change like proposed here).

Actions #4

Updated by Marius BĂLTEANU almost 5 years ago

Here is the patch.

Mischa The Evil wrote:

I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the actual field (border) itself is sufficient. We might want to get some feedback on that as some users may have patched/changed the core in such a way that it has custom field styling which may conflict with such a change (however, such shouldn't block a change like proposed here).

Initially, I tried only the field (border), but because all labels are bold, it wasn't obvious enough for me. Anyway, any option works for me.

Actions #5

Updated by Go MAEDA almost 5 years ago

  • Target version set to 4.2.0

This is a nice UI improvement!

Setting the target version to 4.2.0.

Actions #6

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for improving Redmine.

Actions #7

Updated by Go MAEDA almost 4 years ago

  • Related to Defect #34580: Custom field labels do not contain class "error" when the field value is invalid added
Actions

Also available in: Atom PDF