Defect #32768

Internal Error when issue text custom field is shown in Spent time query results

Added by Sebastian Paluch 10 months ago. Updated 10 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Time tracking
Target version:4.1.1
Resolution:Fixed Affected version:4.1.0

Description

On Spent Time tab, when selecting, under Options->Show, a custom field of long text type, I get internal error:

Processing by TimelogController#index as HTML
  Parameters: {"c"=>["spent_on", "user", "activity", "issue", "comments", "hours", "issue.cf_47"], "columns"=>"month", "criteria"=>[""], "encoding"=>"ISO-8859-1", "f"=>["spent_on", ""], "group_by"=>"", "op"=>{"spent_on"=>"*"}, "set_filter"=>"1", "sort"=>"spent_on:desc", "t"=>["hours", ""], "utf8"=>"✓", "project_id"=>"test"}
  Current user: admin (id=164)
  Rendering timelog/index.html.erb within layouts/base
  Rendered queries/_filters.html.erb (3.5ms)
  Rendered queries/_columns.html.erb (1.3ms)
  Rendered queries/_query_form.html.erb (6.6ms)
  Rendered timelog/_date_range.html.erb (7.9ms)
  Rendered timelog/_list.html.erb (299.2ms)
  Rendered timelog/index.html.erb within layouts/base (377.5ms)
Completed 500 Internal Server Error in 468ms (ActiveRecord: 24.3ms)

ActionView::Template::Error (undefined local variable or method `issue' for #<#<Class:0x000000000ca4e780>:0x000000000ca474f8>
Did you mean?  issue_url):
    50:         <%= link_to_context_menu %>
    51:     </td>
    52:   </tr>
    53:   <% @query.block_columns.each do |column|
    54:        if (text = column_content(column, issue)) && text.present? -%>
    55:   <tr class="<%= current_cycle %>">
    56:     <td colspan="<%= @query.inline_columns.size + 1 %>" class="<%= column.css_classes %>">

app/views/timelog/_list.html.erb:53:in `block (3 levels) in _app_views_timelog__list_html_erb__281615036_105133860'
app/views/timelog/_list.html.erb:52:in `each'
app/views/timelog/_list.html.erb:52:in `block (2 levels) in _app_views_timelog__list_html_erb__281615036_105133860'
app/helpers/queries_helper.rb:154:in `block in grouped_query_results'
app/helpers/queries_helper.rb:139:in `each'
app/helpers/queries_helper.rb:139:in `grouped_query_results'
app/views/timelog/_list.html.erb:17:in `block in _app_views_timelog__list_html_erb__281615036_105133860'
app/views/timelog/_list.html.erb:1:in `_app_views_timelog__list_html_erb__281615036_105133860'
app/views/timelog/index.html.erb:27:in `_app_views_timelog_index_html_erb__57510300_106046780'
app/controllers/timelog_controller.rb:57:in `block (2 levels) in index'
app/controllers/timelog_controller.rb:51:in `index'
lib/redmine/sudo_mode.rb:65:in `sudo_mode'

environment:

Environment:
  Redmine version                4.1.0.stable
  Ruby version                   2.5.7-p206 (2019-10-01) [x64-mingw32]
  Rails version                  5.2.4.1
  Environment                    production
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.11.1
  Git                            2.19.1
  Filesystem                     
Redmine plugins:
  no plugin installed

0001-Fix-Internal-Error-when-issue-text-custom-field-is-s.patch Magnifier (2.12 KB) Marius BALTEANU, 2020-01-10 18:20


Related issues

Related to Redmine - Feature #16843: Enable grouping on time entries list Closed
Related to Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear... Closed

Associated revisions

Revision 19419
Added by Go MAEDA 10 months ago

Fix Internal Error when issue text custom field is shown in Spent time query results (#32768).

Patch by Marius BALTEANU.

Revision 19420
Added by Go MAEDA 10 months ago

Merged r19419 from trunk to 4.1-stable (#32768).

History

#1 Updated by Marius BALTEANU 10 months ago

  • Status changed from New to Confirmed
  • Assignee set to Marius BALTEANU
  • Target version set to 4.1.1

#2 Updated by Marius BALTEANU 10 months ago

The problem in timelog/_list.html.erb was introduced by #16843, but until #26081 was implemented, there were no inline columns for TimeEntryQuery.

I'll post soon the fix.

#3 Updated by Marius BALTEANU 10 months ago

  • Related to Feature #16843: Enable grouping on time entries list added

#4 Updated by Marius BALTEANU 10 months ago

  • Related to Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column) added

#5 Updated by Marius BALTEANU 10 months ago

  • File 0001-Fix-Internal-Error-when-issue-text-custom-field-is-s.patch added
  • Assignee deleted (Marius BALTEANU)

Here is the fix.

#6 Updated by Marius BALTEANU 10 months ago

  • File deleted (0001-Fix-Internal-Error-when-issue-text-custom-field-is-s.patch)

#8 Updated by Go MAEDA 10 months ago

  • Subject changed from Spent Time query results with Internal Error when text custom field is shown to Internal Error when issue text custom field is shown in Spent time query results
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Also available in: Atom PDF