Project

General

Profile

Actions
Copy link

Defect #32832

closed

FrozenError when exporting content to PDF in some languages

Added by Pavel Rosický almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
PDF export
Target version:
4.1.1
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

reported on https://github.com/naitoh/rbpdf/issues/55

Files

Download all files
fix_pdfexport.patch (1.46 KB) fix_pdfexport.patch Pavel Rosický, 2020-01-17 20:11
fix_pdfexport2.patch (1.3 KB) fix_pdfexport2.patch Pavel Rosický, 2020-01-18 08:45
Actions
Copy link
 #1

Updated by Go MAEDA almost 5 years ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
  • Target version set to 4.1.1

I think the change in SetFontStyle can be ommitted and fixing only SetFont is enough. What do you think?

diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index c8189367b..85beb8bdb 100644
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -52,6 +52,7 @@ module Redmine
         end

         def SetFont(family, style='', size=0, fontfile='')
+          style = +style
           # FreeSerif Bold Thai font has problem.
           style.delete!('B') if family.to_s.casecmp('freeserif') == 0
           # DejaVuSans Italic Arabic and Persian font has problem.
Actions
Copy link
 #2

Updated by Pavel Rosický almost 5 years ago

you're right

Actions
Copy link
 #4

Updated by Go MAEDA almost 5 years ago

  • Subject changed from pdf export - frozen error to FrozenError when exporting gantt to PDF in some languages
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

Actions
Copy link
 #5

Updated by Go MAEDA almost 5 years ago

  • Subject changed from FrozenError when exporting gantt to PDF in some languages to FrozenError when exporting content to PDF in some languages
Actions
Copy link

Also available in: Atom PDF