Project

General

Profile

Actions

Defect #32860

closed

Invalid links to versions with sharing in project tree

Added by Alexander Meindl about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Roadmap
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If a version uses sharing in project tree, there are invalid links in the roadmap overview.

The problem occurs, if the version is in a sub-directory and in the project root. Than there are missing permissions to issues (e.g. if issue module is disabled or current user has no rights to see issues in root project).

The attached patch fixes this problem. The patch is for trunk, but the problem is also available in 4.0.x and 4.1.x.


Files

fix_link_to_version.patch (721 Bytes) fix_link_to_version.patch Alexander Meindl, 2020-01-24 16:32
new_test_and_fix.patch (1.78 KB) new_test_and_fix.patch Alexander Meindl, 2020-01-25 09:36
32860-confirmed.png (182 KB) 32860-confirmed.png Go MAEDA, 2020-06-25 16:29
32860-v2.patch (2.11 KB) 32860-v2.patch Go MAEDA, 2020-07-04 03:30
Actions #1

Updated by Marius BÄ‚LTEANU about 4 years ago

Thanks for the patch. Can you add a test case for this scenario?

Actions #2

Updated by Alexander Meindl about 4 years ago

Here is a test for this patch. This patch also correct link to shared version with hierarchy. Without this patch, version link uses the root project for hierarchy versions - which is not correct imho. Versions with hierarchy should use link to current project.

I hope this test is sufficient. Let me know, if more information is required.

Actions #3

Updated by Go MAEDA almost 4 years ago

Confirmed the issue.

In the screenshot below, the link "1 issue" and "1 open" point to it parent project (ecookbook"). If "Issue tracking" module is disabled in "ecookbook" project, 403 error page is displayed when you click either of the two links.

Actions #4

Updated by Go MAEDA almost 4 years ago

Combined fix_link_to_version.patch and attach:new_test_and_fix.patch, and update it for the current trunk (r19851).

Actions #5

Updated by Go MAEDA over 3 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions #6

Updated by Go MAEDA over 3 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Actions

Also available in: Atom PDF