Patch #32909

Replace pluck().first with pick()

Added by Pavel Rosický over 1 year ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:-

Description

https://github.com/rails/rails/pull/31941

pick.patch Magnifier (2.98 KB) Pavel Rosický, 2020-01-28 23:03

pick2.patch Magnifier (2.41 KB) Pavel Rosický, 2020-01-28 23:06

0001-Replace-pluck-.first-with-pick.patch Magnifier (6.47 KB) Marius BALTEANU, 2021-04-02 22:50

Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 New

Associated revisions

Revision 20907
Added by Go MAEDA 4 months ago

Replace pluck().first with pick() (#32909).

Patch by Pavel Rosický and Marius BALTEANU.

History

#1 Updated by Pavel Rosický over 1 year ago

#2 Updated by Marius BALTEANU over 1 year ago

#3 Updated by Marius BALTEANU over 1 year ago

  • Target version set to 5.0.0

Looks good to me.

#4 Updated by Marius BALTEANU 4 months ago

  • Target version deleted (5.0.0)

#5 Updated by Marius BALTEANU 4 months ago

  • Assignee set to Marius BALTEANU

#6 Updated by Marius BALTEANU 4 months ago

I've rebased the patches added by Pavel, the changes looks good to me.

#7 Updated by Marius BALTEANU 4 months ago

  • Assignee changed from Marius BALTEANU to Go MAEDA

#8 Updated by Go MAEDA 4 months ago

  • Subject changed from Rails 6: use Relation#pick to Replace pluck().first with pick()
  • Status changed from New to Closed
  • Target version set to 5.0.0

Committed the patch. Thank you.

#9 Updated by Marius BALTEANU 4 months ago

  • Target version deleted (5.0.0)

Also available in: Atom PDF