Project

General

Profile

Actions
Copy link

Patch #32909

closed

Replace pluck().first with pick()

Added by Pavel Rosický almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

https://github.com/rails/rails/pull/31941

Files

Download all files
pick.patch (2.98 KB) pick.patch Pavel Rosický, 2020-01-28 23:03
pick2.patch (2.41 KB) pick2.patch Pavel Rosický, 2020-01-28 23:06
0001-Replace-pluck-.first-with-pick.patch (6.47 KB) 0001-Replace-pluck-.first-with-pick.patch Marius BĂLTEANU, 2021-04-02 22:50

Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadingClosedGo MAEDA

Actions
Actions
Copy link
 #2

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Actions
Copy link
 #3

Updated by Marius BĂLTEANU almost 5 years ago

  • Target version set to 5.0.0

Looks good to me.

Actions
Copy link
 #4

Updated by Marius BĂLTEANU over 3 years ago

  • Target version deleted (5.0.0)
Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 3 years ago

  • Assignee set to Marius BĂLTEANU
Actions
Copy link
 #6

Updated by Marius BĂLTEANU over 3 years ago

I've rebased the patches added by Pavel, the changes looks good to me.

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 3 years ago

  • Assignee changed from Marius BĂLTEANU to Go MAEDA
Actions
Copy link
 #8

Updated by Go MAEDA over 3 years ago

  • Subject changed from Rails 6: use Relation#pick to Replace pluck().first with pick()
  • Status changed from New to Closed
  • Target version set to 5.0.0

Committed the patch. Thank you.

Actions
Copy link
 #9

Updated by Marius BĂLTEANU over 3 years ago

  • Target version deleted (5.0.0)
Actions
Copy link

Also available in: Atom PDF