Patch #32922

reload detached attachments

Added by Pavel Rosický 12 months ago. Updated 12 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

use #reload instead, after upgrading to Rails 5

acts_as_attachable.rb.patch Magnifier (552 Bytes) Pavel Rosický, 2020-01-30 00:56


Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6 New

History

#1 Updated by Marius BALTEANU 12 months ago

Thanks Pavel for posting the patches for Rails 6 update.

I've applied this patch on the current trunk and a test fails:

 Failure:
 AttachmentsTest#test_upload_and_resubmit_after_validation_failure [/builds/redmine-org/redmine/test/integration/attachments_test.rb:113]:
 Expected at least 1 element matching "input[name="attachments[p0][description]"][value="My uploaded file"]", found 0..
 Expected 0 to be >= 1.
 bin/rails test test/integration/attachments_test.rb:99

You can see the test results here.

#2 Updated by Marius BALTEANU 12 months ago

#3 Updated by Pavel Rosický 12 months ago

  • Status changed from New to Resolved

sry, thanks for catching this, I was confused about the comment. Closing

#4 Updated by Marius BALTEANU 12 months ago

  • Status changed from Resolved to New

Let's keep it open, maybe we can fix the issue.

Also available in: Atom PDF