Actions
Defect #32959
closedFix selected user on log time edit page when user has permissions to log time for another user
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
when you're editing a existing timelog entry and have the rights to adjust the user ( or log on behalf of another user ), the current value will not be selected in the drop down due to this line:
the fix is quite simple, just drop the .to_s
selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id == selected
and its working.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index b40f42ecc..e13825082 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -575,7 +575,7 @@ module ApplicationHelper end groups = +'' collection.sort.each do |element| - selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id == selected + selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id.to_s == selected (element.is_a?(Group) ? groups : s) << %(<option value="#{element.id}"#{selected_attribute}>#{h element.name}</option>) end unless groups.empty?
Files
Related issues
Updated by almost 5 years ago
missed the selected version, this applies to 4.1-stable
Updated by Go MAEDA almost 5 years ago
- Related to Feature #3848: Permission to log time for another user added
Updated by Go MAEDA almost 5 years ago
- Tracker changed from Patch to Defect
- Status changed from New to Confirmed
- Target version set to Candidate for next minor release
- Affected version set to 4.1.0
Updated by Marius BĂLTEANU almost 5 years ago
- Assignee set to Marius BĂLTEANU
- Target version changed from Candidate for next minor release to 4.1.1
Updated by Marius BĂLTEANU almost 5 years ago
- File 0001-Fix-selected-user-on-timelog-edit.patch 0001-Fix-selected-user-on-timelog-edit.patch added
Thanks easter egg for detecting the issue.
I have attached a patch that fixes the code added in #3848 and adds a test for this case. Regarding your fix from app/helpers/application_helper.rb
, maybe it's better to cast both values to_s
.
Updated by Marius BĂLTEANU almost 5 years ago
- Subject changed from fix for selected user on timelogentry edit to Fix selected user on log time edit page when user has permissions to log time for another user
- Assignee deleted (
Marius BĂLTEANU)
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116202079
Updated by Go MAEDA almost 5 years ago
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you.
Actions