Defect #32973

Editing a time entry for a locked user changes the user to the current user

Added by Marius BALTEANU 12 days ago. Updated 12 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Time tracking
Target version:4.1.1
Resolution: Affected version:4.1.0

Description

Steps to reproduce:

1. Add a time entry for another user (B)
2. Lock that user (B)
3. Edit the time entry
4. Observe that field User is selected with "me".

Saving the time entry, it will lose the user.

me.png (50.4 KB) Marius BALTEANU, 2020-02-08 21:48

0002-Reorder-and-rename-test-added-in-32959.patch Magnifier (1.69 KB) Marius BALTEANU, 2020-02-09 15:21

0001-Allow-editing-a-time-entry-logged-on-a-locked-user.patch Magnifier (3.75 KB) Marius BALTEANU, 2020-02-09 15:21


Related issues

Related to Redmine - Feature #3848: Permission to log time for another user Closed 2009-09-11

History

#1 Updated by Marius BALTEANU 12 days ago

  • Related to Feature #3848: Permission to log time for another user added

#2 Updated by Marius BALTEANU 12 days ago

I see two options to fix this:

1. We don't allow changing the user when the time entry is logged on a locked user.
2. We add the locked user to the list of users.

#3 Updated by Go MAEDA 12 days ago

Marius BALTEANU wrote:

I see two options to fix this:

1. We don't allow changing the user when the time entry is logged on a locked user.
2. We add the locked user to the list of users.

I think the second option is better because the limitation suggested in option 1 may confuse users. In my opinion, there is no reason to disallow changing the user when the user of the time entry is locked.

#4 Updated by Marius BALTEANU 12 days ago

Here is the fix for the second option, but I would like a double check on the solution. The second patch renames and reorders the test added in #32959.

All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116292306

Also available in: Atom PDF