Redmine

here's a new patch including a migration to delete already existing orphaned values.

The patch cannot be committed for minor releases because it has a migration.

Setting the target version to 4.2.0.

Jens, I've reviewed the patch and it looks good to me, except the test that fails:

➜  redmine git:(patch/32977) ✗ ruby test/unit/user_test.rb -n test_remove_custom_field_references_upon_destroy
Skipping LDAP tests.
Run options: -n test_remove_custom_field_references_upon_destroy --seed 57996

# Running:

F

Failure:
UserTest#test_remove_custom_field_references_upon_destroy [test/unit/user_test.rb:1341]:
#<Proc:0x00007fcf93fa35d8@test/unit/user_test.rb:1341 (lambda)> didn't change by -2.
Expected: 20
  Actual: 19

I think the problem is in the test because the following update:

issue.update(custom_field_values:
{
  cf1.id => @jsmith.id,
  cf2.id => [@dlopper.id, @jsmith.id]
})

diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb
index e2dec070c..42011f759 100644
--- a/test/unit/user_test.rb
+++ b/test/unit/user_test.rb
@@ -1336,7 +1336,7 @@ class UserTest < ActiveSupport::TestCase
     assert cv2a = cv2.detect{|cv| cv.value == @dlopper.id.to_s}
     assert cv2b = cv2.detect{|cv| cv.value == @jsmith.id.to_s}

-    assert_difference ->{CustomValue.count}, -2 do
+    assert_difference ->{CustomValue.count}, -3 do
       @jsmith.destroy
     end

Jens Krämer wrote:

I just tried and it passes here (MySQL 5.6, Ruby 2.6).

Since we delete jsmith (but not dlopper), the custom value for @dlopper should not be affected. I have no clue why the test fails for you though.

Thanks, you're right, user @dlopper should not be affected, I will take again a look. It doesn't fail only on my local environment, it fails also on the custom Gitlab CI.